Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0037057

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2017-10-11 15:55

2017-10-27 12:49

Reporter

aaroncalero

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

normal

Resolution

fixed

Fixed in Version

RR18Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0037057: Mandatory Services search should be blocked while the calculateReceipt function is being executed

Description

When a product is added to a ticket and there are mandatory services related to said product, the mandatory services search is opened and the services are listed right away, while the calculateReceipt function might still be executing.
Some functionalities might require the total of the lines to be calculated (i.e. the Automatic Service Price Rule Calculation: org.openbravo.retail.services.autoprice) before showing the service list

Steps To Reproduce

Login in web pos
Open the browser console and execute this[1] code to add a hook that slows down the calculateReceipt process.
Go to the Search tab, search for the Blue Trousers product and add it to the ticket.
The Mandatory services search will be shown, and after 5 seconds the total of the ticket will be correctly calculated.

[1] OB.UTIL.HookManager.registerHook('OBPOS_PreApplyAutomaticDiscount', function(args, callback){
setTimeout(function(){
OB.UTIL.HookManager.callbackExecutor(args, callback);
}, 5000)
})

Proposed Solution

Attached diffs with the following changes:
Postermina: When the calculateReceipt has finished, trigger the 'calculatedReceipt' event on the receipt model.
Mobile Core: Instead of launching the service search right away, if the calculateReceipt is still pending wait for the 'calculatedReceipt' event to trigger the search.

Tags

No tags attached.

Issue37057_Posterminal.diff [^] (757 bytes) 2017-10-11 16:07 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -770,10 +770,12 @@
               executeCallback(me.get('calculateReceiptCallbacks'), function () {
                 me.calculatingReceipt = false;
                 OB.MobileApp.view.waterfall('calculatedReceipt');
+                me.trigger('calculatedReceipt');
               });
             } else {
               me.calculatingReceipt = false;
               OB.MobileApp.view.waterfall('calculatedReceipt');
+              me.trigger('calculatedReceipt');
             }
           }
         });

Issue37057_MobileCore.diff [^] (1,784 bytes) 2017-10-11 16:08 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js b/web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
--- a/web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
+++ b/web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
@@ -1073,7 +1073,8 @@
     }, this);
 
     this.receipt.on('showProductList', function (line, proposalType, finalCallback) {
-      var previousStatus, customFilters = [];
+      var previousStatus, customFilters = [],
+          me = this;
       if (proposalType && proposalType === 'mandatory') {
         this.customFilters.forEach(function (customFilter) {
           if (customFilter.type === 'BUTTON') {
@@ -1123,12 +1124,25 @@
       this.bubble('onTabChange', {
         tabPanel: 'searchCharacteristic'
       });
-      this.doSearchAction({
-        productCat: '__all__',
-        productName: '',
-        skipProduct: false,
-        skipProductCharacteristic: false
-      });
+
+      function serviceSearchAction() {
+        me.receipt.off('calculatedReceipt', serviceSearchAction);
+        if (OB.MobileApp.model.get('serviceSearchMode')) {
+          me.doSearchAction({
+            productCat: '__all__',
+            productName: '',
+            skipProduct: false,
+            skipProductCharacteristic: false
+          });
+        }
+      }
+      if (me.receipt.calculatingReceipt) {
+        me.$.products.hide();
+        me.$.renderLoading.show();
+        me.receipt.on('calculatedReceipt', serviceSearchAction);
+      } else {
+        serviceSearchAction();
+      }
 
       if (proposalType) {
         this.doManageServiceProposal({

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0099992) hgbot (developer) 2017-10-23 13:00	Repository: erp/pmods/org.openbravo.mobile.core Changeset: fa427f5256aa97b295fb15aa846ea97bf4be2c6b Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Oct 23 16:18:06 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fa427f5256aa97b295fb15aa846ea97bf4be2c6b [^] Fixed issue 37057 : Show Product Services after calculateReceipt completed --- M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js ---

(0100018) hgbot (developer) 2017-10-24 12:05	Repository: erp/pmods/org.openbravo.mobile.core Changeset: ab7e3eb2ff506c5d564376e6e792aa7c5dde6adf Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Oct 24 15:23:59 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ab7e3eb2ff506c5d564376e6e792aa7c5dde6adf [^] Related to issue 37057 : Removed unused warning while searching services --- M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js ---

Issue History
Date Modified	Username	Field	Change
2017-10-11 15:55	aaroncalero	New Issue
2017-10-11 15:55	aaroncalero	Assigned To	=> Retail
2017-10-11 15:55	aaroncalero	Resolution time	=> 1508882400
2017-10-11 15:55	aaroncalero	Triggers an Emergency Pack	=> No
2017-10-11 16:07	aaroncalero	File Added: Issue37057_Posterminal.diff
2017-10-11 16:08	aaroncalero	File Added: Issue37057_MobileCore.diff
2017-10-19 11:55	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2017-10-19 11:55	ranjith_qualiantech_com	Status	new => scheduled
2017-10-23 13:00	hgbot	Checkin
2017-10-23 13:00	hgbot	Note Added: 0099992
2017-10-23 13:00	hgbot	Status	scheduled => resolved
2017-10-23 13:00	hgbot	Resolution	open => fixed
2017-10-23 13:00	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fa427f5256aa97b295fb15aa846ea97bf4be2c6b [^]
2017-10-24 12:05	hgbot	Checkin
2017-10-24 12:05	hgbot	Note Added: 0100018
2017-10-27 12:49	marvintm	Review Assigned To	=> marvintm
2017-10-27 12:49	marvintm	Status	resolved => closed
2017-10-27 12:49	marvintm	Fixed in Version	=> RR18Q1

Copyright © 2000 - 2009 MantisBT Group