Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036694
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2017-08-22 14:032018-01-03 12:39
ReporterngarciaView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revisionce48d1e0930a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036694: In Currency window, POS precision can be higher than the currency's real precision (commonly 2)

DescriptionIn Currency window, POS precision can be higher than the currency's real precision (commonly 2)

The POS Precision is used to round all the amounts and prices of the documents created in the POS. As the majority of currencies do not allow to pay an amount lower than 0.01, a warning could be shown when the POS precision is defined with a value higher than 2 or when it is empty and the price precision is higher than 2 (as Price Precision is used as POS Precision when this is empty)
Steps To ReproduceAs System Admin role:
   Go to EUR currency and check you can save the record with the following values and it is not correct:
      Price Precision: 6
      Pos Precision: empty

   Go to EUR currency and check you can save the record with the following values and it is not correct:
      Pos Precision: 6
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0036693 closedmarkmm82 Openbravo ERP In Currency window, Standard precision can be higher than the currency's real precision (commonly 2) 
related to design defect 0033762 newRetail Retail Modules POS precision is not aligned with options available in backoffice: this can create "inconsistent" orders between channels 
related to defect 0042929 closedAtulOpenbravo Openbravo ERP Wrong warning shown when trying to change the standard precision of a currency to a value higher than 2 

-  Notes
(0098861)
ngarcia (developer)
2017-09-06 13:46

 Currency codes - ISO 4217:

https://www.iso.org/iso-4217-currency-codes.html [^]
(0100561)
hgbot (developer)
2017-11-17 08:34

 Repository: erp/devel/pi
Changeset: 6488f29c70a0831c3e9e3052b2b86a778f78e154
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Nov 15 13:37:59 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6488f29c70a0831c3e9e3052b2b86a778f78e154 [^]

Related to issue 36694. Related to issue 36693

The code related to the ISO currency precision included in the callout has
been moved to a new class called ISOCurrencyPrecision. Now, the
method getCurrencyPrecisionInISO4217Spec is public.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Currency_StdPrecision.java
A src/org/openbravo/erpCommon/utility/ISOCurrencyPrecision.java
---
(0100563)
hgbot (developer)
2017-11-17 08:34

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ce48d1e0930ae73731c405d4e66b04592a16388f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Nov 15 13:29:42 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ce48d1e0930ae73731c405d4e66b04592a16388f [^]

Fixed issue 36694: In Currency window, POS precision can be higher than the
currency's real precision (commonly 2)

The solution is to implement a new callout linked to POS precision to check
if the value is correct.

---
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
A src/org/openbravo/retail/posterminal/ad_callouts/POSCurrencyPrecision.java
---
(0100627)
hgbot (developer)
2017-11-20 17:08

 Repository: erp/devel/pi
Changeset: 72ca71e6b78a340ee3126792286f5bf970d7c673
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Nov 20 12:01:56 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/72ca71e6b78a340ee3126792286f5bf970d7c673 [^]

Related to issue 36694. Related to issue 36693

 * Fix problem with log messages in the new API
 * Added copyright to ISOCurrencyPrecision
 * Added class Javadoc to ISOCurrencyPrecision
 * Use getResourceAsStream to read the xml file with the standard
   currency precisions.

---
M src/org/openbravo/erpCommon/utility/ISOCurrencyPrecision.java
---
(0101429)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test
(0101442)
hudsonbot (developer)
2018-01-03 12:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c81e0d3cbab5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-08-22 14:03 ngarcia New Issue
2017-08-22 14:03 ngarcia Assigned To => Retail
2017-08-22 14:03 ngarcia Triggers an Emergency Pack => No
2017-08-22 14:03 ngarcia Relationship added related to 0036693
2017-08-22 14:03 ngarcia Relationship added related to 0033762
2017-09-06 13:46 ngarcia Note Added: 0098861
2017-11-15 13:56 jorge-garcia Status new => scheduled
2017-11-15 13:56 jorge-garcia Assigned To Retail => jorge-garcia
2017-11-17 08:34 hgbot Checkin
2017-11-17 08:34 hgbot Note Added: 0100561
2017-11-17 08:34 hgbot Checkin
2017-11-17 08:34 hgbot Note Added: 0100563
2017-11-17 08:34 hgbot Status scheduled => resolved
2017-11-17 08:34 hgbot Resolution open => fixed
2017-11-17 08:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ce48d1e0930ae73731c405d4e66b04592a16388f [^]
2017-11-20 17:08 hgbot Checkin
2017-11-20 17:08 hgbot Note Added: 0100627
2017-12-07 13:53 marvintm Review Assigned To => marvintm
2017-12-07 13:53 marvintm Status resolved => closed
2017-12-07 13:53 marvintm Fixed in Version => RR18Q1
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101429
2018-01-03 12:39 hudsonbot Checkin
2018-01-03 12:39 hudsonbot Note Added: 0101442
2020-01-17 12:54 ngarcia Relationship added related to 0042929

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker