Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036059
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2017-05-22 10:202017-06-01 15:55
ReporteradrianromeroView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revision60a8bc0a21cd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036059: [SER-QA 2863] If synchronization fails in the server side, the message displayed in WEB POS is not appropriate

DescriptionIn synchronized mode, after data is sent to the server side and fails, a dialog is displayed in Web POS : "The transaction failed on the server, change your input or try again. Detailed error message: " Adding the error message coming from the server side. The problem is that depending on the case the error is not appropriate for the user showing technical and low level details.

See the attached screenshot displayed when an order fails because of taxes error.
Steps To Reproduce* Activate synchronized mode. Set preference "WEB POS Synchronized mode" to "Y"
* Force a wrong order with taxes errors. This can be done for example if fix for related issue 0035829 is not applied
* Close the order and observe the error displayed in Web POS
Proposed SolutionThe problem goes in this line: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/51504365e8e1/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l1256 [^]
Where it is displayed directly the message coming from the server. Some options to fix the problem are:

* Send for the server side a friendly message in case of taxes error and also other errors displayed.
* Ignore the message coming form the server side, Just display an error has been thrown by the server, contact a systems administrator
* Display a message just saying there has been an error coming from the server side with a button for "extended information for system administrators" that displays the full error coming from the server.
 
TagsSER-QA
Attached Filesjpeg file icon image1.jpeg [^] (76,560 bytes) 2017-05-22 10:57

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035829 closedmario_castello [SER-QA 2729] Lines with a tax error are not deleted 

-  Notes
(0096854)
hgbot (developer)
2017-05-29 14:13

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ad3d4f504577d86c101bc497a40df78c5f66c34c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 29 17:43:03 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ad3d4f504577d86c101bc497a40df78c5f66c34c [^]

Fixes issue 36059 : Changed Transaction failed message in Synchronized mode while syncing models

* Instead of showing full error message from server, Simple message should be shown to user and Server error message should be logged

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0097006)
marvintm (manager)
2017-05-30 12:06

 We need to generate a specific message in the OrderLoader in case we get null tax information
(0097068)
hgbot (developer)
2017-06-01 10:06

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d4c5cd0d499032e9566caa9d58e4373609f3d078
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 01 08:56:03 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d4c5cd0d499032e9566caa9d58e4373609f3d078 [^]

Related to issue 36059 : Validation error message added in OrderLoader

Backed out changeset: ad3d4f504577

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0097069)
hgbot (developer)
2017-06-01 10:06

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7fd0755c388c5b94ffcc698e508297fd5421f59f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 01 13:35:38 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7fd0755c388c5b94ffcc698e508297fd5421f59f [^]

Fixed issue 36059 : Validate Order line should have tax information in OrderLoader

* Show Error to user, if order line doesn't have tax informations

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0097076)
marvintm (manager)
2017-06-01 13:16

 The validation is not executed correctly, because the loaded property is not reliable. Instead, it should be moved to the part of Orderloader which updates taxes.
(0097077)
hgbot (developer)
2017-06-01 15:17

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 60a8bc0a21cd6a9efdc9aaab34a52df1fde17656
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 01 18:46:12 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/60a8bc0a21cd6a9efdc9aaab34a52df1fde17656 [^]

Fixed issue 36059 : Validate Order line must have tax information in OrderLoader before creating Order

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2017-05-22 10:20 adrianromero New Issue
2017-05-22 10:20 adrianromero Assigned To => Retail
2017-05-22 10:20 adrianromero Resolution time => 1496613600
2017-05-22 10:20 adrianromero Triggers an Emergency Pack => No
2017-05-22 10:22 adrianromero Tag Attached: SER-QA
2017-05-22 10:57 adrianromero File Added: image1.jpeg
2017-05-22 12:03 adrianromero Relationship added depends on 0035829
2017-05-22 12:07 adrianromero Steps to Reproduce Updated View Revisions
2017-05-22 12:07 adrianromero Proposed Solution updated
2017-05-22 12:08 adrianromero Relationship replaced related to 0035829
2017-05-25 14:55 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2017-05-25 14:55 ranjith_qualiantech_com Status new => scheduled
2017-05-29 14:13 hgbot Checkin
2017-05-29 14:13 hgbot Note Added: 0096854
2017-05-29 14:13 hgbot Status scheduled => resolved
2017-05-29 14:13 hgbot Resolution open => fixed
2017-05-29 14:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ad3d4f504577d86c101bc497a40df78c5f66c34c [^]
2017-05-30 12:06 marvintm Note Added: 0097006
2017-05-30 12:06 marvintm Status resolved => new
2017-05-30 12:06 marvintm Resolution fixed => open
2017-05-30 13:44 ranjith_qualiantech_com Status new => scheduled
2017-06-01 10:06 hgbot Checkin
2017-06-01 10:06 hgbot Note Added: 0097068
2017-06-01 10:06 hgbot Checkin
2017-06-01 10:06 hgbot Note Added: 0097069
2017-06-01 10:06 hgbot Status scheduled => resolved
2017-06-01 10:06 hgbot Resolution open => fixed
2017-06-01 10:06 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ad3d4f504577d86c101bc497a40df78c5f66c34c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7fd0755c388c5b94ffcc698e508297fd5421f59f [^]
2017-06-01 13:16 marvintm Note Added: 0097076
2017-06-01 13:16 marvintm Status resolved => new
2017-06-01 13:16 marvintm Resolution fixed => open
2017-06-01 14:18 ranjith_qualiantech_com Status new => scheduled
2017-06-01 15:17 hgbot Checkin
2017-06-01 15:17 hgbot Note Added: 0097077
2017-06-01 15:17 hgbot Status scheduled => resolved
2017-06-01 15:17 hgbot Resolution open => fixed
2017-06-01 15:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7fd0755c388c5b94ffcc698e508297fd5421f59f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/60a8bc0a21cd6a9efdc9aaab34a52df1fde17656 [^]
2017-06-01 15:55 marvintm Review Assigned To => marvintm
2017-06-01 15:55 marvintm Status resolved => closed
2017-06-01 15:55 marvintm Fixed in Version => RR17Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker