Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0035714 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
design defect | [Retail Modules] StoreServer | minor | have not tried | 2017-04-06 16:47 | 2017-04-18 09:44 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | f20b3eb2ecba | ||||
Projection | none | ETA | none | Target Version | RR17Q2.1 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | AugustoMauch | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0035714: Prevent NPE if multi-server is not enabled | |||||||
Description | If Multi-server is not enabled then there is no mobile service definition. This code [1] will then give a NPE. [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/06f73df68ba0/src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestAllowedHandler.java#l51 [^] | |||||||
Steps To Reproduce | Run system with the module, do not set mobile.server.key | |||||||
Proposed Solution | If mobile server definition is null then allow request | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0095883) hgbot (developer) 2017-04-06 23:56 |
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: f20b3eb2ecbad4b424c305dfecd47ff4673ee080 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Apr 06 23:56:26 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/f20b3eb2ecbad4b424c305dfecd47ff4673ee080 [^] Fixes issue 35714: Prevent NPE if multi-server is not enabled Prevent NPE --- M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestAllowedHandler.java --- |
(0096047) AugustoMauch (manager) 2017-04-18 09:44 |
Code reviewed and verified |
Issue History | |||
Date Modified | Username | Field | Change |
2017-04-06 16:47 | mtaal | New Issue | |
2017-04-06 16:47 | mtaal | Assigned To | => mtaal |
2017-04-06 16:47 | mtaal | Triggers an Emergency Pack | => No |
2017-04-06 23:56 | hgbot | Checkin | |
2017-04-06 23:56 | hgbot | Note Added: 0095883 | |
2017-04-06 23:56 | hgbot | Status | new => resolved |
2017-04-06 23:56 | hgbot | Resolution | open => fixed |
2017-04-06 23:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/f20b3eb2ecbad4b424c305dfecd47ff4673ee080 [^] |
2017-04-10 16:31 | mtaal | Review Assigned To | => AugustoMauch |
2017-04-18 09:44 | AugustoMauch | Note Added: 0096047 | |
2017-04-18 09:44 | AugustoMauch | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |