Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0034787 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] Y. DBSourceManager | minor | have not tried | 2016-12-20 14:03 | 2019-03-11 09:58 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | shuehner | |||||||
Priority | high | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | ded71ebe5165 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | vmromanos | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0034787: DBinconsistency in 1 view between 9.3 & 9.5 versions of postgres which seems to need dbsm changes | |||||||
Description | The module org.openbravo.warehouse.piclinglist has a view OBWPL_PICKINGLIST_PICK_EDIT which exports differently on PostgreSQL 9.3 and 9.5 and both exported versions are not useful for the other postgres version. If not other view syntax can be found working out of the box on both looks like dbsourcemanager needs to be changed to support this. | |||||||
Steps To Reproduce | Current pi Clone the following 2 modules (note: 1st is just dependency of 2nd and itself not interesting here) https://code.openbravo.com/erp/pmods/org.openbravo.warehouse.structure [^] https://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist [^] install.source using PostgreSQL 9.5 Mark pickinligst module as in development: - update ad_module set isindevelopment = 'Y' where javapackage = 'org.openbravo.warehouse.pickinglist'; - run export.database - Notice diff creating 1 extra set of parantheses 2nd environment same pi with same modules - run install.source with PostgreSQL 9.3 - Apply this diff from above - run update.database - set module in development also - run export.database -> See that diff is not maintained but 'removed' again. That means there seems to be no easy identical xml for the moment which is compatible between 9.3 and 9.5 for this view - | |||||||
Tags | No tags attached. | |||||||
Attached Files | org.openbravo.warehouse.pickinglist.dbcons95.diff [^] (6,235 bytes) 2016-12-20 14:04 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0092856) shuehner (administrator) 2016-12-20 14:04 |
Example diff of export.db on PostgreSQL 9.5 compared to tip of the module repo. |
(0110331) hgbot (developer) 2019-03-10 19:24 |
Repository: erp/pmods/org.openbravo.warehouse.pickinglist Changeset: ded71ebe516565655c94055fe367eee8ea0b5538 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Sun Mar 10 18:34:10 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/ded71ebe516565655c94055fe367eee8ea0b5538 [^] Fixed 34787. Avoid dbconsistency issue with PostgreSQL >=9.5 As explained in issue 34787 there is a non-solvable dbconsistency issue with this view depending on postgres version. When exporting it with PostgreSQL >= 9.5 an extra set of parenthesis is added: from - COALESCE(sd.m_attributesetinstance_id, '0'), to - (COALESCE(sd.m_attributesetinstance_id, '0')), This is a formal change only with no functional impact. As preparation to move Openbravo CI to default to PostgreSQL 10 when running test commit this change once to get a clean export on this newer version. Note: This will create the inverse problem when running dbconsistency check on older postgres like 9.3 (no issue as not tested by default in CI anymore soon). --- M src-db/database/model/views/OBWPL_PICKINGLIST_PICK_EDIT.xml --- |
(0110336) vmromanos (manager) 2019-03-11 09:58 |
Code review OK |
Issue History | |||
Date Modified | Username | Field | Change |
2016-12-20 14:03 | shuehner | New Issue | |
2016-12-20 14:03 | shuehner | Assigned To | => platform |
2016-12-20 14:03 | shuehner | Modules | => Core |
2016-12-20 14:03 | shuehner | Triggers an Emergency Pack | => No |
2016-12-20 14:04 | shuehner | Note Added: 0092856 | |
2016-12-20 14:04 | shuehner | File Added: org.openbravo.warehouse.pickinglist.dbcons95.diff | |
2016-12-21 09:39 | alostale | Status | new => acknowledged |
2019-03-10 19:24 | hgbot | Checkin | |
2019-03-10 19:24 | hgbot | Note Added: 0110331 | |
2019-03-10 19:24 | hgbot | Status | acknowledged => resolved |
2019-03-10 19:24 | hgbot | Resolution | open => fixed |
2019-03-10 19:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/ded71ebe516565655c94055fe367eee8ea0b5538 [^] |
2019-03-10 19:25 | shuehner | Assigned To | platform => shuehner |
2019-03-10 19:25 | shuehner | Review Assigned To | => vmromanos |
2019-03-11 09:58 | vmromanos | Note Added: 0110336 | |
2019-03-11 09:58 | vmromanos | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |