Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2015-05-27 16:022015-06-17 20:06
ReportermarvintmView Statuspublic 
Assigned Toaaroncalero 
PriorityurgentResolutionfixedFixed in VersionRR15Q3
StatusclosedFix in branchFixed in SCM revisiona5c25afa2d03
ProjectionnoneETAnoneTarget VersionRR15Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - Confirmed Stable
Regression date2014-08-02
Regression introduced in releaseRR14Q4
Regression introduced by commit [^]
Triggers an Emergency PackNo

0030032: Pay button is enabled in the Receipt discounts tab, and allows the user to enter a wrong state in the Web POS

DescriptionWhen the Receipt discounts tab is enabled, all the buttons in the toolbar should be disabled, to force the user to either apply a discount, or close the tab. However, the Pay button is enabled, so the user can mistakenly enter a wrong state, in which most of the Web POS is disabled, so the user becomes stuck and the only option is to refresh the window.
Steps To Reproduce- Log in the Web POS
- Add some products to the ticket
- Go to Receipt Discounts option in the menu
- Realize that the Pay (total) button is enabled. This is not correct.
- Click on the Pay button. Realize that you are now in an incorrect state, the menu is disabled, and you basically can only pay, but if you do you are still in this incorrect state, and the only solution is to refresh the page.
Proposed Solution- The Pay button should be disabled in the Receipt discounts tab, like it was in 2014Q3 release.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0030034RR15Q2.2 closedaaroncalero Pay button is enabled in the Receipt discounts tab, and allows the user to enter a wrong state in the Web POS 
depends on backport 0030035RR15Q1.5 closedaaroncalero Pay button is enabled in the Receipt discounts tab, and allows the user to enter a wrong state in the Web POS 
caused by defect 0027268RR14Q4 closedOrekaria Stabilization: Improve the enabling/disabling of the pay button 
blocks feature request 0029530RR16Q1 closedRetail QA: RR15Q3: Add tests for Mobile applications 

-  Notes
hgbot (developer)
2015-05-29 09:14

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 41c037b78e4f437ce8e90a8ed4896974e8e2286f
Author: Aaron Calero <aaron.calero <at>>
Date: Fri May 29 09:01:34 2015 +0200
URL: [^]

Fixed issue 30032: Pay button is enabled in the Receipt discounts tab

The problem was that the Synchronization Helper was sending 'synchronized' events while the discounts tab was open, enabling the button.
A check has been added to disable the button (or keep it disabled) if a request to disable it has been done, or if the this.isEnabled attribute is false (meaning that the toolbar has been disabled).

M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
Orekaria (administrator)
2015-05-29 09:54

That method was refactored to be able to log the status of the button each time that it is called

With your changes for that special cases (are not all special?), we will no longer be able to log why the button has been disabled which, as said, was the only reason to refactor the method

Please add the exceptions to the requirements object and be sure that, in the line 275, the error log is not shown with those 2 requirements
hgbot (developer)
2015-05-29 12:59

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a5c25afa2d03d167b2fa6a8b01d9efe8f554081b
Author: Aaron Calero <aaron.calero <at>>
Date: Fri May 29 12:47:57 2015 +0200
URL: [^]

Fixed issue 30032: Pay button is enabled in the Receipt discounts tab

Refactored the way the function checks the isDisabled parameter and the this.isEnabled attributes to be used within the requirementsAreMet function.
Added several comments.

M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
dmitry_mezentsev (developer)
2015-05-29 13:55 [^]
Orekaria (administrator)
2015-06-16 23:27

Added 'I30032_PayButtonWithDiscretionaryDiscounts' test
hgbot (developer)
2015-06-17 20:06

Repository: tools/automation/pi-mobile
Changeset: e003430ab8f3ed5c269a705429d0c9fd5780fb24
Author: Aaron Calero <aaron.calero <at>>
Date: Thu May 28 12:10:18 2015 +0200
URL: [^]

Related to issue 28933, verifies issue 30032: Added 'I30032_PayButtonWithDiscretionaryDiscounts' test

M src-test/org/openbravo/test/mobile/common/selenium/javascript/
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/paybutton/

- Issue History
Date Modified Username Field Change
2015-05-27 16:02 marvintm New Issue
2015-05-27 16:02 marvintm Assigned To => aaroncalero
2015-05-27 16:02 marvintm Regression level => Production - Confirmed Stable
2015-05-27 16:02 marvintm Triggers an Emergency Pack => No
2015-05-28 01:02 marvintm Status new => scheduled
2015-05-28 12:36 aaroncalero Regression date => 2014-08-02
2015-05-28 12:36 aaroncalero Regression introduced in release => RR14Q4
2015-05-28 12:36 aaroncalero Regression introduced by commit => [^]
2015-05-29 09:14 hgbot Checkin
2015-05-29 09:14 hgbot Note Added: 0077881
2015-05-29 09:14 hgbot Status scheduled => resolved
2015-05-29 09:14 hgbot Resolution open => fixed
2015-05-29 09:14 hgbot Fixed in SCM revision => [^]
2015-05-29 09:54 Orekaria Note Added: 0077883
2015-05-29 09:54 Orekaria Status resolved => new
2015-05-29 09:54 Orekaria Resolution fixed => open
2015-05-29 12:59 hgbot Checkin
2015-05-29 12:59 hgbot Note Added: 0077889
2015-05-29 12:59 hgbot Status new => resolved
2015-05-29 12:59 hgbot Resolution open => fixed
2015-05-29 12:59 hgbot Fixed in SCM revision [^] => [^]
2015-05-29 13:50 dmitry_mezentsev Relationship added caused by 0027268
2015-05-29 13:55 dmitry_mezentsev Note Added: 0077896
2015-05-29 13:55 dmitry_mezentsev Severity major => minor
2015-06-11 17:55 marvintm Review Assigned To => marvintm
2015-06-11 17:55 marvintm Status resolved => closed
2015-06-11 17:55 marvintm Fixed in Version => RR15Q3
2015-06-16 19:34 Orekaria Relationship added blocks 0029530
2015-06-16 23:27 Orekaria Note Added: 0078338
2015-06-17 20:06 hgbot Checkin
2015-06-17 20:06 hgbot Note Added: 0078350

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker