Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029984
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] SEPA Credit Transfer Customer-to-Bankmajoralways2015-05-22 14:242015-05-28 09:56
ReporterngarciaView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision6aaf6bcd45b0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket36154
OBNetwork customerOBPS
Regression introduced in release
Summary

0029984: Bank Instruction description's last character is removed when adding it to the ustrd field

DescriptionBank Instruction description's last character is removed when adding it to the ustrd field
Steps To ReproduceAs group admin role:
   Create a Remittance with Remittance type "SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)" and process it
   Check a Bank Instructions record has a description and if not add it
   Create Remittance File and check the last character is removed from that description
   Repeat the process with "SEPA Credit Transfer Customer-to-Bank (pain.001.001.04)" and check the same problem happens
Proposed SolutionThe problem is in the following code of the CreditTransfer.java file:

          remInfo7.getUstrd()
              .add(
                  parseText(line.getDescription().substring(
                      0,
                      line.getDescription().length() > 140 ? 139
                          : line.getDescription().length() - 1)));
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0029983 closedjorge-garcia Bank Instruction description's last character is removed when adding it to the ustrd field 

-  Notes
(0077809)
jorge-garcia (viewer)
2015-05-27 15:31

 Test Plan

As group admin role:
   Create a Remittance with Remittance type "SEPA Credit Transfer Customer-to-Bank (pain.001.001.03)" and process it
   Check a Bank Instructions record has a description and if not add it (to check properly, try with a description with less than 140, more than 140 and exactly 140 characters).
   Create Remittance File and check the description is filled correctly.
   Repeat the process with "SEPA Credit Transfer Customer-to-Bank (pain.001.001.04)" and check the the description is filled correctly.
(0077856)
hgbot (developer)
2015-05-28 09:54

 Repository: erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank
Changeset: 6aaf6bcd45b0600fd64ad922a6b3b866651e207d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed May 27 15:24:43 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/6aaf6bcd45b0600fd64ad922a6b3b866651e207d [^]

Fixed issue 29984: Bank Instruction description's last character is removed

Bank Instruction description's last character is removed when adding it to the
USTRD field.

The problem was that the description only takes the first 139 characters instead
of the 140 allowed. Also, if you have blank spaces before and after the
description, these blank spaces counts for the count of the string and the
description is filled wrong. If the string length was smaller than 140
characters, the last character of the string is also deleted.

The solution is to check if the string has more than 140 characters. If so, we
retrieve the first 140 characters excluding blank spaces. If is lesser than 140
characters, the function don't do anything.

---
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x03/report/CreditTransfer.java
M src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x04/report/CreditTransfer.java
---
(0077857)
vmromanos (viewer)
2015-05-28 09:56

 Code review + testing OK

Available in SEPA Credit Transfer Customer-to-Bank 1.0.6 or higher

- Issue History
Date Modified Username Field Change
2015-05-22 14:24 ngarcia New Issue
2015-05-22 14:24 ngarcia Assigned To => Triage Finance
2015-05-22 14:24 ngarcia Support ticket => 36154
2015-05-22 14:24 ngarcia OBNetwork customer => Yes
2015-05-22 14:24 ngarcia Issue generated from 0029983
2015-05-22 14:25 ngarcia Steps to Reproduce Updated View Revisions
2015-05-22 14:25 ngarcia Issue Monitored: networkb
2015-05-22 14:29 ngarcia Resolution time => 1435269600
2015-05-22 14:29 ngarcia Proposed Solution updated
2015-05-22 14:31 ngarcia Relationship added related to 0029983
2015-05-27 15:31 jorge-garcia Note Added: 0077809
2015-05-27 15:32 jorge-garcia Status new => scheduled
2015-05-27 15:32 jorge-garcia Assigned To Triage Finance => jorge-garcia
2015-05-28 09:54 hgbot Checkin
2015-05-28 09:54 hgbot Note Added: 0077856
2015-05-28 09:54 hgbot Status scheduled => resolved
2015-05-28 09:54 hgbot Resolution open => fixed
2015-05-28 09:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/rev/6aaf6bcd45b0600fd64ad922a6b3b866651e207d [^]
2015-05-28 09:56 vmromanos Review Assigned To => vmromanos
2015-05-28 09:56 vmromanos Note Added: 0077857
2015-05-28 09:56 vmromanos Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker