Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029264
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] I. Performancemajorsometimes2015-03-06 13:372015-04-01 08:31
ReporterlorenzofidalgoView Statuspublic 
Assigned Toumartirena 
PrioritynormalResolutionfixedFixed in Version3.0PR15Q1.2
StatusclosedFix in branchFixed in SCM revision74bfc587053f
ProjectionnoneETAnoneTarget Version3.0PR15Q1.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned ToSandrahuguet
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029264: Clicking select all and after that unselect all records in AddPayment window induces browser to get stuck

DescriptionIf there is enough lines (I have tested this with 60 and 90 records and it has been successfully reproduced), clicking "select all" records and after that clicking same button (which is "unselect all" at that moment) induces browser to get stuck. [See screenshots].

I have tested this localhost and livebuilds in pi pgsql context.

Steps To Reproduce[It is adviced to create as many puchase invoice records as possible with at least one product line each one and complete them to test this].

Login ERP using QAAdmin role.
Go to "Financial Account" window.
Select "Spain Cashbook" role.
Go to "Transaction" tab.
Create a new record.
Transaction Type: "BP Withdrawal".
Click "+" in Payment field to add a payment.
In "Add Payment" window:
--
Clear filters.
Click "select all" checkbox and next to that, click it again to "unselect all".
It will probably broke. If it does not, repeat "select all" + "unselect all" several times.
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate backport 00293403.0PR15Q1.2 closedumartirena Clicking select all and after that unselect all records in AddPayment window induces browser to get stuck 
blocks defect 0029172 closedumartirena Clicking select all and after that unselect all records in AddPayment window induces browser to get stuck 

-  Notes
(0075558)
hgbot (developer)
2015-03-13 13:44

 Repository: erp/backports/3.0PR15Q1.2
Changeset: 74bfc587053f9082559e655408e26a91f7582d85
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Fri Mar 13 13:00:24 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/74bfc587053f9082559e655408e26a91f7582d85 [^]

Fixes bug 29264 Improved performance select/deselect all records in OrderInv grid

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0075563)
Sandrahuguet (developer)
2015-03-13 13:59

 Code review + testing OK
(0075716)
umartirena (reporter)
2015-03-18 09:19

 Reopened because it does not update differences after reload of Order Invoices grid
(0075751)
hgbot (developer)
2015-03-18 18:32

 Repository: erp/backports/3.0PR15Q1.2
Changeset: 5a949354221bc1c20087a9ced726f7d2640228cb
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Mar 18 18:30:39 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/5a949354221bc1c20087a9ced726f7d2640228cb [^]

Related to bug 29264: Delete obaprmAllRecordsSelectedByUser in OrderInvoice Load

While executing invalidateCache() function to reload OrderInvoice grid it internally calls to 'OB.APRM.AddPayment.deselectAllRecords' overriden method that sets obaprmAllRecordsSelectedByUser property to true. This property is only needed when manually the select/unselect all checkbox is clicked.

This was causing on certain scenarios that methods to update totals were not being called:
* OB.APRM.AddPayment.updateInvOrderTotal(view.theForm, orderInvoice);
* OB.APRM.AddPayment.updateActualExpected(view.theForm);
* OB.APRM.AddPayment.updateDifference(view.theForm);

So, in order to avoid this in OrderInvoiceOnLoad function, if the property 'obaprmAllRecordsSelectedByUser' exists, it will be deleted.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0075754)
Sandrahuguet (developer)
2015-03-18 19:02

 Code review + testing OK
(0076212)
hgbot (developer)
2015-04-01 08:07

 Repository: erp/backports/3.0PR15Q2
Changeset: 74bfc587053f9082559e655408e26a91f7582d85
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Fri Mar 13 13:00:24 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/74bfc587053f9082559e655408e26a91f7582d85 [^]

Fixes bug 29264 Improved performance select/deselect all records in OrderInv grid

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0076222)
hgbot (developer)
2015-04-01 08:08

 Repository: erp/backports/3.0PR15Q2
Changeset: 5a949354221bc1c20087a9ced726f7d2640228cb
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Mar 18 18:30:39 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/5a949354221bc1c20087a9ced726f7d2640228cb [^]

Related to bug 29264: Delete obaprmAllRecordsSelectedByUser in OrderInvoice Load

While executing invalidateCache() function to reload OrderInvoice grid it internally calls to 'OB.APRM.AddPayment.deselectAllRecords' overriden method that sets obaprmAllRecordsSelectedByUser property to true. This property is only needed when manually the select/unselect all checkbox is clicked.

This was causing on certain scenarios that methods to update totals were not being called:
* OB.APRM.AddPayment.updateInvOrderTotal(view.theForm, orderInvoice);
* OB.APRM.AddPayment.updateActualExpected(view.theForm);
* OB.APRM.AddPayment.updateDifference(view.theForm);

So, in order to avoid this in OrderInvoiceOnLoad function, if the property 'obaprmAllRecordsSelectedByUser' exists, it will be deleted.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0076261)
priyam (administrator)
2015-04-01 08:31

 closed again, as the status changed due the merge tag of 3.0PR15Q1.2 to backports/3.0PR15Q2

- Issue History
Date Modified Username Field Change
2015-03-12 17:10 Sandrahuguet Type defect => backport
2015-03-12 17:10 Sandrahuguet Target Version => 3.0PR15Q1.2
2015-03-13 13:44 hgbot Checkin
2015-03-13 13:44 hgbot Note Added: 0075558
2015-03-13 13:44 hgbot Status scheduled => resolved
2015-03-13 13:44 hgbot Resolution open => fixed
2015-03-13 13:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/74bfc587053f9082559e655408e26a91f7582d85 [^]
2015-03-13 13:59 Sandrahuguet Review Assigned To => Sandrahuguet
2015-03-13 13:59 Sandrahuguet Note Added: 0075563
2015-03-13 13:59 Sandrahuguet Status resolved => closed
2015-03-13 13:59 Sandrahuguet Fixed in Version => 3.0PR15Q1.2
2015-03-13 17:35 dmitry_mezentsev Tag Attached: Approved
2015-03-18 09:19 umartirena Note Added: 0075716
2015-03-18 09:19 umartirena Status closed => new
2015-03-18 09:19 umartirena Resolution fixed => open
2015-03-18 09:19 umartirena Fixed in Version 3.0PR15Q1.2 =>
2015-03-18 18:32 hgbot Checkin
2015-03-18 18:32 hgbot Note Added: 0075751
2015-03-18 18:33 umartirena Status new => scheduled
2015-03-18 18:38 umartirena Relationship deleted depends on 0029340
2015-03-18 18:38 umartirena Relationship added has duplicate 0029340
2015-03-18 18:40 umartirena Status scheduled => resolved
2015-03-18 18:40 umartirena Fixed in Version => 3.0PR15Q1.2
2015-03-18 18:40 umartirena Resolution open => fixed
2015-03-18 19:02 Sandrahuguet Note Added: 0075754
2015-03-18 19:02 Sandrahuguet Status resolved => closed
2015-04-01 08:07 hgbot Checkin
2015-04-01 08:07 hgbot Note Added: 0076212
2015-04-01 08:07 hgbot Status closed => resolved
2015-04-01 08:07 hgbot Fixed in SCM revision http://code.openbravo.com/erp/backports/3.0PR15Q1.2/rev/74bfc587053f9082559e655408e26a91f7582d85 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/74bfc587053f9082559e655408e26a91f7582d85 [^]
2015-04-01 08:08 hgbot Checkin
2015-04-01 08:08 hgbot Note Added: 0076222
2015-04-01 08:31 priyam Status resolved => closed
2015-04-01 08:31 priyam Note Added: 0076261

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker