Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028691 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | major | always | 2015-01-20 13:20 | 2015-02-24 23:09 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | reinaldoguerra | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | b699e6284720 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028691: It is possible to add discounts to documents already processed | |||||||
| Description | It is possible to add discounts to documents already processed. The C_ORDERDISCOUNT_TRG trigger is prepared to handle this situation but the trigger is not configured to be executed on insert. | |||||||
| Steps To Reproduce | 1) Go to the [Sales Order] window 2) Select an already processed order 3) Go to the [Basic Discounts] tab. Notice that it is possible to add a new record. | |||||||
| Proposed Solution | Configure the C_ORDERDISCOUNT_TRG to be executed ON INSERT | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0074031) reinaldoguerra (developer) 2015-02-03 14:26 |
Test plan used: 1- Go to the [Sales Order] window 2- Select an already processed order 3- Go to the [Basic Discounts] tab. Notice that it is not possible to add a new record: An error message is shown |
|
(0074807) hgbot (developer) 2015-02-23 15:20 |
Repository: erp/devel/pi Changeset: b699e6284720b0d5690633863231c9c4db132283 Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com> Date: Mon Feb 02 16:24:12 2015 -0500 URL: http://code.openbravo.com/erp/devel/pi/rev/b699e6284720b0d5690633863231c9c4db132283 [^] Fixed bug 28691: It is possible to add discounts to documents already processed. One possible solution for this issue would be to configure the C_ORDERDISCOUNT_TRG to be executed ON INSERT action, but this trigger is launched also when inserting orders for business partners with discounts defined, so the trigger logic causes a "mutating table" oracle's error. In this case a new event handler is developed, to launch an error message, when trying to insert discounts for a sales order already processed. This change also affects the following windows: Purchase Order, Return from Customer, Return to Vendor and Sales Quotation. --- A src/org/openbravo/event/OrderDiscountEventHandler.java --- |
|
(0074808) aferraz (manager) 2015-02-23 15:23 |
Code review + Testing OK |
|
(0074890) hudsonbot (developer) 2015-02-24 23:09 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6c8e140b31ec [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-01-20 13:20 | caristu | New Issue | |
| 2015-01-20 13:20 | caristu | Assigned To | => dmiguelez |
| 2015-01-20 13:20 | caristu | Modules | => Core |
| 2015-01-20 13:20 | caristu | Resolution time | => 1424646000 |
| 2015-01-20 13:20 | caristu | Triggers an Emergency Pack | => No |
| 2015-01-20 13:20 | caristu | Issue Monitored: networkb | |
| 2015-01-20 13:21 | caristu | Assigned To | dmiguelez => AtulOpenbravo |
| 2015-01-30 15:38 | reinaldoguerra | Assigned To | AtulOpenbravo => reinaldoguerra |
| 2015-01-30 15:38 | reinaldoguerra | Status | new => scheduled |
| 2015-02-03 14:26 | reinaldoguerra | Note Added: 0074031 | |
| 2015-02-23 09:48 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
| 2015-02-23 11:03 | Sandrahuguet | Review Assigned To | Sandrahuguet => aferraz |
| 2015-02-23 15:20 | hgbot | Checkin | |
| 2015-02-23 15:20 | hgbot | Note Added: 0074807 | |
| 2015-02-23 15:20 | hgbot | Status | scheduled => resolved |
| 2015-02-23 15:20 | hgbot | Resolution | open => fixed |
| 2015-02-23 15:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/b699e6284720b0d5690633863231c9c4db132283 [^] |
| 2015-02-23 15:23 | aferraz | Note Added: 0074808 | |
| 2015-02-23 15:23 | aferraz | Status | resolved => closed |
| 2015-02-24 23:09 | hudsonbot | Checkin | |
| 2015-02-24 23:09 | hudsonbot | Note Added: 0074890 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |