Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027640
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2014-09-18 18:032014-09-23 08:31
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionfixedFixed in VersionRR14Q4
StatusclosedFix in branchFixed in SCM revision208a8f23b274
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027640: Errors in OB.Dal.save callbacks should not rollback the transaction.

DescriptionThe OB.Dal.save function:

OB.Dal.save = function (model, success, error, forceInsert)
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/da6fd82667d5/web/org.openbravo.mobile.core/source/data/ob-dal.js#l330 [^]

If the 'success' callback function throws an error, the websql transaction is rolled back

It is assumed in all calls to the OB.Dal.save that an error in the success callback does not have to rollback the transaction
Steps To ReproduceIn the line: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/79500303f4b7/web/org.openbravo.retail.posterminal/js/data/dataordersave.js#l109 [^]

Throw an error:

throw "error";

And verify that when closing an order, the order is kept in the websql database as not paid
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0070247)
hgbot (developer)
2014-09-22 18:18

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 208a8f23b274b045c7522106e6c55f1a13b315a7
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Sep 22 18:16:57 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/208a8f23b274b045c7522106e6c55f1a13b315a7 [^]

Fixes issue 0027640: Errors in OB.Dal.save callbacks should not rollback the transaction.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0070263)
migueldejuana (developer)
2014-09-23 08:31

tested and reviewed in dac0cfbd526b

- Issue History
Date Modified Username Field Change
2014-09-18 18:03 adrianromero New Issue
2014-09-18 18:03 adrianromero Assigned To => adrianromero
2014-09-18 18:03 adrianromero Triggers an Emergency Pack => No
2014-09-18 18:12 adrianromero Review Assigned To => marvintm
2014-09-22 16:19 mtaal Target Version RR14Q4 =>
2014-09-22 18:18 hgbot Checkin
2014-09-22 18:18 hgbot Note Added: 0070247
2014-09-22 18:18 hgbot Status new => resolved
2014-09-22 18:18 hgbot Resolution open => fixed
2014-09-22 18:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/208a8f23b274b045c7522106e6c55f1a13b315a7 [^]
2014-09-23 08:31 migueldejuana Review Assigned To marvintm => migueldejuana
2014-09-23 08:31 migueldejuana Note Added: 0070263
2014-09-23 08:31 migueldejuana Status resolved => closed
2014-09-23 08:31 migueldejuana Fixed in Version => RR14Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker