0027310: Check if transaction is active in DalBaseProcess

Description

Hi,
I get the stacktrace below in a process.

gr. Martin

fff0bb6f 2014-08-11 14:27:01,890 [DefaultQuartzScheduler_Worker-6] ERROR org.openbravo.base.util.CheckException - Tx is not active
org.openbravo.base.util.CheckException: Tx is not active
        at org.openbravo.base.util.Check.isTrue(Check.java:51)
        at org.openbravo.dal.core.SessionHandler.checkInvariant(SessionHandler.java:350)
        at org.openbravo.dal.core.SessionHandler.commitAndClose(SessionHandler.java:252)
        at org.openbravo.dal.service.OBDal.commitAndClose(OBDal.java:174)
        at org.openbravo.service.db.DalBaseProcess.execute(DalBaseProcess.java:98)
        at org.openbravo.scheduling.DefaultJob.execute(DefaultJob.java:58)
        at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
        at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)
fff0bb6f 2014-08-11 14:27:01,892 [DefaultQuartzScheduler_Worker-6] ERROR org.openbravo.scheduling.DefaultJob - Error executing process org.openbravo.scheduling.ProcessBundle@b83ade0
org.hibernate.SessionException: Session was already closed
        at org.hibernate.impl.SessionImpl.close(SessionImpl.java:320)
        at org.openbravo.dal.core.SessionHandler.closeSession(SessionHandler.java:156)
        at org.openbravo.dal.core.SessionHandler.commitAndClose(SessionHandler.java:281)
        at org.openbravo.dal.service.OBDal.commitAndClose(OBDal.java:174)
        at org.openbravo.service.db.DalBaseProcess.execute(DalBaseProcess.java:98)
        at org.openbravo.scheduling.DefaultJob.execute(DefaultJob.java:58)
        at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
        at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:525)

Steps To Reproduce

Create a process which commits the transaction but does not close the session.

Proposed Solution

Do a check if the transaction is still active before doing commit and close.

It is important to solve this as it results in not-needed errors in the log.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0072579) shuehner (administrator) 2014-12-16 22:11	i think that is a duplicate or some other duplicate exists for the same topic. See bugs reported for errors in some ci job.

Issue History
Date Modified	Username	Field	Change
2014-08-11 20:34	mtaal	New Issue
2014-08-11 20:34	mtaal	Assigned To	=> AugustoMauch
2014-08-11 20:34	mtaal	Modules	=> Core
2014-08-11 20:34	mtaal	Triggers an Emergency Pack	=> No
2014-09-29 08:31	alostale	Target Version	3.0PR14Q4 => 3.0PR15Q1
2014-12-16 22:11	shuehner	Note Added: 0072579
2014-12-22 10:53	alostale	Target Version	3.0PR15Q1 =>
2015-03-11 11:23	alostale	Status	new => acknowledged
2015-03-17 14:38	alostale	Assigned To	AugustoMauch => platform
2022-02-01 08:05	alostale	Assigned To	platform => Triage Platform Base