0015559: DAL: Add support to @#Date@ as default value for a column

Description

Right now is impossible to define a default value for a column to "today" in a way that both the UI and DAL understand it.

For example:
-if we define the default value in the AD for a column to "SYSDATE", DAL will understand it but the UI won't do it (it will display the string SYSDATE into the field)
-if we define the default value in the AD for a column to "@#Date@", the UI will understand it but the DAL won't do it (it will use null as a default value)

This is a problem when both DAL and the UI use this column's default value. An example can be a new date column in the AD_ORG table, because for creating a new organization we can use the DAL through the Initial Org Setup or the UI through the Organization window

Proposed Solution

See attached patch (please review it)

Tags

No tags attached.

Attached Files

dal_today.diff [^] (884 bytes) 2010-12-31 11:47 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/base/model/Property.java b/src/org/openbravo/base/model/Property.java
--- a/src/org/openbravo/base/model/Property.java
+++ b/src/org/openbravo/base/model/Property.java
@@ -342,6 +342,12 @@
       }
     }
 
+    if (defaultValue != null && (isDate() || isDatetime())) {
+      if (defaultValue.equalsIgnoreCase("@#Date@")) {
+        return " new java.util.Date()";
+      }
+    }
+
     if (defaultValue != null && isPrimitive()) {
       if (defaultValue.startsWith("@")) {
         return null;
@@ -427,6 +433,12 @@
       }
     }
 
+    if (defaultValue != null && (isDate() || isDatetime())) {
+      if (defaultValue.equalsIgnoreCase("@#Date@")) {
+        return new Date();
+      }
+    }
+
     if (defaultValue != null && isPrimitive()) {
       // strip the ' and ;
       if (defaultValue.startsWith("'") && defaultValue.endsWith("'")) {

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

feature request

0013601

closed

vmromanos

"Valid from Date" field in Organization

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2010-12-31 11:47	vmromanos	New Issue
2010-12-31 11:47	vmromanos	Assigned To	=> alostale
2010-12-31 11:47	vmromanos	File Added: dal_today.diff
2010-12-31 11:47	vmromanos	Modules	=> Core
2010-12-31 11:49	vmromanos	Relationship added	blocks 0013601
2017-04-10 14:39	alostale	Assigned To	alostale => platform
2022-02-01 08:08	alostale	Assigned To	platform => Triage Platform Base