Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0057721 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] POS | major | always | 2024-12-20 17:13 | 2025-01-27 11:19 | |||
| Reporter | Daria_Sh | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 25Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0057721: OTF Coupon can be created and applied with a negative or zero 'Number of Uses Limit' value | |||||||
| Description | When a zero or negative value is entered as the 'Number of Uses Limit' in the OTF Rule in the Backoffice, the rule is saved, and the OTF Coupon can still be generated and applied in the POS. Pre - configurations: 1. Go to 'Discounts and Promotions' window 2. Open 'Test Coupon' discount 3. Tick 'Uses coupon codes' and 'Is OTF Coupon' flags 4. Ensure discount is active 5. Go to 'OTF Coupons Generation Rules' window 6. Create new Rule → Fulfill the following fields: - Applicant, Search Key, Description and Starting Date - Active: ✔ - Issuance Time: At Paid Time - Promotion/Discount: Test Coupon - Number of Uses: N Uses - Number of Uses Limit: 0|-1 7. Proceed to 'Print' tab → Fulfill the required fields 8. Launch the HW manager | |||||||
| Steps To Reproduce | 1. Login to POS (livebuilds:vallblanca/openbravo) 2. Add product to the Order 3. Complete the Order (Click 'Pay', select 'Cash' and click 'Done') 4. Select 'Print' delivery option 5. Verify the printed Coupon in the HW manager Actual Result: The Coupon is printed and saved in the BO (Discount Coupon window) with 'Number of Uses Limit' equal to 0 or -1 6. Add product to the Order 7. Scan or redeem Coupon Code Actual Result: The coupon is applied | |||||||
| Proposed Solution | The validation should be set for this field preventing to save OTF rule with zero or negative value in 'Number of Uses Limit' field | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0174593) hgbot (developer) 2025-01-23 15:03 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/68 [^] |
|
(0174741) hgbot (developer) 2025-01-27 11:19 |
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/68 [^] |
|
(0174742) hgbot (developer) 2025-01-27 11:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^] Changeset: 8927973cb2e6e4bfc78e5425bc59852a1b5f05b9 Author: Ranjith S R <r.rangaraju@external.orisha.com> Date: 23-01-2025 19:25:34 URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/8927973cb2e6e4bfc78e5425bc59852a1b5f05b9 [^] Fixed ISSUE-57721: Added Event Handler to validate min value of UsesLimit and Discount --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/retail/discounts/coupons/otf/event/CouponrulesEventHandler.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2025-01-22 13:01 | javierRodriguez | Type | defect => backport |
| 2025-01-22 13:01 | javierRodriguez | Target Version | => 25Q1 |
| 2025-01-23 15:03 | hgbot | Note Added: 0174593 | |
| 2025-01-27 11:19 | hgbot | Note Added: 0174741 | |
| 2025-01-27 11:19 | hgbot | Resolution | open => fixed |
| 2025-01-27 11:19 | hgbot | Status | scheduled => closed |
| 2025-01-27 11:19 | hgbot | Note Added: 0174742 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |