Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0057632 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Cash up | major | always | 2025-01-13 16:47 | 2025-01-16 16:00 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | migueldejuana | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR25Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR25Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0057632: InitCashup action should not load a cashup from backoffice if the existing cashup in the state is newer | |||||||
| Description | When a cashup is completed in POS, a new cashup is added to the state and the closed cashup is sent to backoffice for processing. However, the closed cashup is not marked as "processed" until its import entry is processed. If the POS performs a login before that import entry is processed, the Global.initCashup action (in one of its actionPreparations[*]) calls the backoffice and retrieves the last non-processed cashup. In this situation, the POS finishes the login process with a cashup that is going to be processed in the server as soon as the import entry is triggered. After performing any action involving that cashup (the Open Till process, a ticket, etc), if the import entry has finished processing, an Error While Importing record will be generated for the related document. [*] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js#L215 [^] | |||||||
| Steps To Reproduce | In a development environment, set a breakpoint inside the saveRecord method of ProcessCashClose.java. Log in POS or POS2. Check the Cashup id in the state: OB.App.State.getState().Cashup.id Navigate to the cashup window and complete the process. The POS will automatically log out. At the same time, the server code will be stopped on the breakpoint; leave the code paused for now. Check the cashup id again. Verify that the id is new. In POS, log in again. Check the cashup id for the third time. Note that the id is the first id again. Let the server code continue and process the cashup. Try to complete a ticket. Verify that a record has been created in the Errors While Importing POS Data window | |||||||
| Proposed Solution | The code that was added as part of previous mitigations should not try to reload the non-processed cashup from backoffice if it is detected that the creationDate of the backoffice cashup is older that the current new cashup in the state. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0174234) hgbot (developer) 2025-01-16 14:23 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1875 [^] |
|
(0174237) hgbot (developer) 2025-01-16 16:00 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1875 [^] |
|
(0174238) hgbot (developer) 2025-01-16 16:00 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: efb46430e4b369a035db80133d5903b262e7b6c0 Author: Sabarinath <s.palanisamy@external.orisha.com> Date: 16-01-2025 18:35:07 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/efb46430e4b369a035db80133d5903b262e7b6c0 [^] Fixed ISSUE-57632: Use Backend Cashup only when it is newer. --- M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2025-01-14 07:31 | migueldejuana | Type | defect => backport |
| 2025-01-14 07:31 | migueldejuana | Target Version | => RR25Q1 |
| 2025-01-16 14:23 | hgbot | Merge Request Status | => open |
| 2025-01-16 14:23 | hgbot | Note Added: 0174234 | |
| 2025-01-16 14:36 | hgbot | Merge Request Status | open => approved |
| 2025-01-16 16:00 | hgbot | Note Added: 0174237 | |
| 2025-01-16 16:00 | hgbot | Resolution | open => fixed |
| 2025-01-16 16:00 | hgbot | Status | scheduled => closed |
| 2025-01-16 16:00 | hgbot | Fixed in Version | => RR25Q1 |
| 2025-01-16 16:00 | hgbot | Note Added: 0174238 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |