Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0056952 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | have not tried | 2024-11-03 11:14 | 2024-11-11 11:50 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR25Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | b205b1fc7f49 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0056952: Remove the "SQL Query" window | |||||||
| Description | This is a very old window which allows: - as System Administrator Role - To run arbitrary SQL queries It comes with various limitations: - Old pre smartclient UI - Not designed for either slow queries or huge result volumes Using it not carefully i.e. on a production machine can cause performance issues for other users or the whole system - It being available for system admin role doesn't allow easy restriction of who has access to run SQL queries - UI/functionality to run SQL queries is something best left to 'outside of the application tools' | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Remove the window/functionality from the product | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0171256) hgbot (developer) 2024-11-03 13:17 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1418 [^] |
|
(0171257) hgbot (developer) 2024-11-03 13:31 |
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/87 [^] |
|
(0171758) hgbot (developer) 2024-11-11 11:48 |
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/87 [^] |
|
(0171760) hgbot (developer) 2024-11-11 11:48 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1418 [^] |
|
(0171761) shuehner (administrator) 2024-11-11 11:49 |
Manually adding commit references as commit pointed to wrong issue id Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/ci/backoffice-api [^] [^] Changeset: 76c5b362ae3adb878391da0b8a96e56662e699c3 Author: Stefan Huehner <s.huehner@orisha.com> Date: 10-11-2024 22:59:35 URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/76c5b362ae3adb878391da0b8a96e56662e699c3 [^] [^] Fixed ISSUE-56592. Remove "SQL Query" window. --- M java/reference/java.japi.gz M model/src-db/database/sourcedata/AD_FORM.xml M model/src-db/database/sourcedata/AD_MENU.xml M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml M model/src-db/database/sourcedata/AD_TREENODE.xml Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] [^] Changeset: b205b1fc7f497e827449705d5bab20ab4bc255c6 Author: Stefan Huehner <s.huehner@orisha.com> Date: 10-11-2024 23:09:12 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/b205b1fc7f497e827449705d5bab20ab4bc255c6 [^] [^] Fixed ISSUE-56592. Remove "SQL Query" window. This was a very old window which allows: - as System Administrator Role - To run arbitrary SQL queries It came with various limitations: - Old pre smartclient UI (xmlEngine, manual html) - Not designed for either slow queries or huge result volumes Using it not carefully i.e. on a production machine could cause performance issues for other users or the whole system - It being available for system admin role didn't allow easy restriction of who had access to run SQL queries - UI/functionality to run SQL queries is something best left to 'outside of the application tools' This also allows small cleanup from the old ToolBar class: - prepareQueryTemplate method was only used by SQLExecutor - search in all product git repos + OBX download did not find any other references. --- M src-db/database/sourcedata/AD_FORM.xml M src-db/database/sourcedata/AD_MENU.xml M src-db/database/sourcedata/AD_MODEL_OBJECT.xml M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml M src-db/database/sourcedata/AD_TEXTINTERFACES.xml M src-db/database/sourcedata/AD_TREENODE.xml M src/org/openbravo/erpCommon/utility/ToolBar.java R src/org/openbravo/erpCommon/ad_forms/SQLExecutor.html R src/org/openbravo/erpCommon/ad_forms/SQLExecutor.java R src/org/openbravo/erpCommon/ad_forms/SQLExecutor.xml R src/org/openbravo/erpCommon/ad_forms/SQLExecutor_Excel.html R src/org/openbravo/erpCommon/ad_forms/SQLExecutor_Excel.xml R src/org/openbravo/erpCommon/ad_forms/SQLExecutor_Query.java R src/org/openbravo/erpCommon/ad_forms/SQLExecutor_data.xsql |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-11-03 11:14 | shuehner | New Issue | |
| 2024-11-03 11:14 | shuehner | Assigned To | => shuehner |
| 2024-11-03 11:14 | shuehner | OBNetwork customer | => No |
| 2024-11-03 11:14 | shuehner | Modules | => Core |
| 2024-11-03 11:14 | shuehner | Triggers an Emergency Pack | => No |
| 2024-11-03 13:17 | hgbot | Merge Request Status | => open |
| 2024-11-03 13:17 | hgbot | Note Added: 0171256 | |
| 2024-11-03 13:31 | hgbot | Note Added: 0171257 | |
| 2024-11-11 00:16 | hgbot | Merge Request Status | open => approved |
| 2024-11-11 11:48 | hgbot | Note Added: 0171758 | |
| 2024-11-11 11:48 | hgbot | Note Added: 0171760 | |
| 2024-11-11 11:49 | shuehner | Note Added: 0171761 | |
| 2024-11-11 11:49 | shuehner | Status | new => scheduled |
| 2024-11-11 11:50 | shuehner | Status | scheduled => resolved |
| 2024-11-11 11:50 | shuehner | Fixed in Version | => PR25Q1 |
| 2024-11-11 11:50 | shuehner | Fixed in SCM revision | => https://gitlab.com/openbravo/product/openbravo/-/commit/b205b1fc7f497e827449705d5bab20ab4bc255c6 [^] |
| 2024-11-11 11:50 | shuehner | Resolution | open => fixed |
| 2024-11-11 11:50 | shuehner | Review Assigned To | => AugustoMauch |
| 2024-11-11 11:50 | shuehner | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |