0056145: Financial account bug in shared payment methods

Description

We have detected a bug when trying to enter a terminal with Master Terminal configured.

When you try to enter a "child" terminal and there is a payment type whose payment method is configured as shared but that payment type is disabled it does not let you enter the terminal.

Debugging we have seen that in the InitValidations file it checks the shared payment methods and if the payment method and the financial account are not the same in the master terminal and the child terminal the OBPOS_FinAccSharedPayment error appears.

The problem is that it is not taking into account whether the payment methods are active or not.

Steps To Reproduce

1-Configure a master terminal (it can be VBS type if it is tested in livebuilds with Vall Blanca) and configure a payment type in which its payment method is shared (in payment methods, it must have the check "Shared payment method").
2-Configure the VBS-1 terminal by placing the master terminal configured before and in its shared payment type place a financial account different from the one of the master terminal.
3-Trying to enter the Web POS of the VBS-1 terminal, an error referring to the financial accounts will be displayed.
4-Disable the shared payment type with a different financial account.
5-Try to enter the Web POS again and verify that the error pops up again. This is because it is not taking into account that the payment type has been deactivated.

Proposed Solution

Patch attached.

Tags

No tags attached.

Attached Files

InitialValidations.diff [^] (871 bytes) 2024-08-01 00:54 [Show Content] [Hide Content]

--- a/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/InitialValidations.java	2024-07-29 12:55:16.467677000 +0200
+++ b/modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/InitialValidations.java	2024-07-29 12:50:35.548061000 +0200
@@ -213,7 +213,7 @@
       List<OBPOSAppPayment> sharedPayments = queryAppPayment.list();
       for (int i = 0; i < posTerminal.getOBPOSAppPaymentList().size(); i++) {
         OBPOSAppPayment appPayment = posTerminal.getOBPOSAppPaymentList().get(i);
-        if (appPayment.getPaymentMethod().isShared()) {
+        if (appPayment.getPaymentMethod().isShared() && appPayment.isActive()) {
           boolean validation = false, nameValidation = false;
           for (int j = 0; j < sharedPayments.size(); j++) {
             OBPOSAppPayment sharedPayment = sharedPayments.get(j);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0167862) hgbot (developer) 2024-08-08 14:01	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1644 [^]

(0168435) hgbot (developer) 2024-08-26 08:34	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1644 [^]

(0168436) hgbot (developer) 2024-08-26 08:34	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: f05b50cca8285d0335083266622ce74be946cc67 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 26-08-2024 04:54:09 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f05b50cca8285d0335083266622ce74be946cc67 [^] Fixed ISSUE-56145: Shared Payment is validated only for active payment and payment method --- M src/org/openbravo/retail/posterminal/InitialValidations.java ---

Issue History
Date Modified	Username	Field	Change
2024-08-01 00:54	axelmercado	New Issue
2024-08-01 00:54	axelmercado	Assigned To	=> Retail
2024-08-01 00:54	axelmercado	File Added: InitialValidations.diff
2024-08-01 00:54	axelmercado	Triggers an Emergency Pack	=> No
2024-08-08 07:44	marvintm	Status	new => acknowledged
2024-08-08 07:45	Rajesh_18	Assigned To	Retail => Rajesh_18
2024-08-08 07:45	Rajesh_18	Status	acknowledged => scheduled
2024-08-08 14:01	hgbot	Note Added: 0167862
2024-08-26 08:34	hgbot	Note Added: 0168435
2024-08-26 08:34	hgbot	Resolution	open => fixed
2024-08-26 08:34	hgbot	Status	scheduled => closed
2024-08-26 08:34	hgbot	Fixed in Version	=> RR24Q4
2024-08-26 08:34	hgbot	Note Added: 0168436