Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055793 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] POS | major | have not tried | 2024-04-26 08:08 | 2024-06-19 16:24 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | Rajesh_18 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 23Q4.3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | 96264 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055793: Error while importing generated when doing the cashup, if the connection is lost at a certain point in the process | |||||||
| Description | It is possible for an Error While importing to happen in certain conditions when doing the cashup, if the connection is lost in some specific moment in time. When this happens, the terminal will go offline, and once it is online again, the user can trigger the cashup completion again, causing an EWI due to a wrong cashup that is containing the same ids that the previously completed cashup also had. | |||||||
| Steps To Reproduce | - Login in the POS and do some sales. - Go to the Cashup window, and count the payment methods (leaving no difference). - When you reach the last step, add a breakpoint in this function, inside the FinishCashup.js file, in dev tools: function addCashupId(payload) { return { ...payload, cashupId: OB.App.State.getState().Cashup.id }; } - Then execute the cashup. The process will stop in the breakpoint you just added - Go to dev tools/Network panel, and set the connectivity to "Without connection" - Continue the process. The user action will fail as there is some post hook that requires connection - Enable connectivity again. - In the POS, change the terminal to online (it will work now because you just enabled connectivity). - Now, realize you can complete the cashup again. Click on the "Finish" button again. - Go to the back office. Verify that you now have an Error While Importing with the following message: org.openbravo.base.exception.OBException: Cashup cannot be processed since error occurred in CashClose: A different object with the same identifier value was already associated with the session : [FIN_Reconciliation#590A06CCA2E08FD9EE354472E0ED81F1] at org.openbravo.retail.posterminal.ProcessCashClose.doReconciliationAndInvoices(ProcessCashClose.java:525) at org.openbravo.retail.posterminal.ProcessCashClose.saveRecord(ProcessCashClose.java:222) at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) at | |||||||
| Proposed Solution | Most probably the easiest solution is to review all postHooks of the action, and make sure we have proper fallbacks for all the cases where a remote request is triggered, so that the user action itself cannot fail if connection is lost at that moment. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0166110) hgbot (developer) 2024-06-19 16:23 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/124 [^] |
|
(0166112) hgbot (developer) 2024-06-19 16:24 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^] Changeset: a19807ec0884bf371fd808bb98300ddd0351756e Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 19-06-2024 19:49:56 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/a19807ec0884bf371fd808bb98300ddd0351756e [^] Fixed ISSUE-55793: Added try-catch for mobile service request --- M web-jspack/org.openbravo.retail.sessions/src/model/till/actions/CloseTillInServer.js --- |
|
(0166113) hgbot (developer) 2024-06-19 16:24 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/124 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-06-19 13:03 | marvintm | Type | defect => backport |
| 2024-06-19 13:03 | marvintm | Target Version | => 24Q1.3 |
| 2024-06-19 13:04 | marvintm | Target Version | 24Q1.3 => 23Q4.3 |
| 2024-06-19 16:23 | hgbot | Note Added: 0166110 | |
| 2024-06-19 16:24 | hgbot | Resolution | open => fixed |
| 2024-06-19 16:24 | hgbot | Status | scheduled => closed |
| 2024-06-19 16:24 | hgbot | Note Added: 0166112 | |
| 2024-06-19 16:24 | hgbot | Note Added: 0166113 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |