0055237: getProcessIdForAudit for TerminalTypeUserConfigurationLoaderProcessor is returning a value higher than 32 and it fails

Description

getProcessIdForAudit for TerminalTypeUserConfigurationLoaderProcessor is returning a value higher than 32 and it fails.

The Data Import Entry related doesn't change to Error and it is always being processed

Steps To Reproduce

Set the SessionInfo to debug

Audit the following tables:

OBPOS_TerminalAccess
Organization
POSS_Terminal_Sessions

Change the configuration of the Terminal from Light mode to Black mode

Check a Data Import Entry of OBPOS2_UpdateTerminalTypeUserConfiguration type is created and it is not processed, it remains an Initial

The log shows:

DEBUG org.openbravo.database.SessionInfo - saving DB context info 4FBFAA553E184EEEA3A60CA1B7DE232D - null - IE - OBPOS2_UpdateTerminalTypeUserConfiguration

org.postgresql.util.PSQLException: ERROR: value too long for type character varying(32)
    at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2676) ~[postgresql-42.5.0.jar:42.5.0]
    at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2366) ~[postgresql-42.5.0.jar:42.5.0]
    at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:356) ~[postgresql-42.5.0.jar:42.5.0]
    at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:496) ~[postgresql-42.5.0.jar:42.5.0]
    at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:413) ~[postgresql-42.5.0.jar:42.5.0]
    at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:190) ~[postgresql-42.5.0.jar:42.5.0]
    at org.postgresql.jdbc.PgPreparedStatement.executeUpdate(PgPreparedStatement.java:152) ~[postgresql-42.5.0.jar:42.5.0]
    at jdk.internal.reflect.GeneratedMethodAccessor227.invoke(Unknown Source) ~[?:?]
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
    at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
    at org.apache.tomcat.jdbc.pool.StatementFacade$StatementProxy.invoke(StatementFacade.java:114) ~[tomcat-jdbc.jar:?]
    at com.sun.proxy.$Proxy70.executeUpdate(Unknown Source) ~[?:?]
    at org.openbravo.database.SessionInfo.saveContextInfoIntoDB(SessionInfo.java:262) ~[openbravo-core.jar:?]
    at org.openbravo.dal.service.OBDal.flush(OBDal.java:263) ~[classes/:?]
    at org.openbravo.dal.core.SessionHandler.flushRemainingChanges(SessionHandler.java:700) ~[classes/:?]
    at org.openbravo.dal.core.SessionHandler.commitAndClose(SessionHandler.java:607) ~[classes/:?]
    at org.openbravo.dal.service.OBDal.commitAndClose(OBDal.java:228) ~[classes/:?]
    at org.openbravo.service.importprocess.ImportEntryManager.setImportEntryErrorIndependent(ImportEntryManager.java:550) ~[classes/:?]
    ... 8 more

Proposed Solution

In modules/org.openbravo.pos2/src/org/openbravo/pos2/importprocess/TerminalTypeUserConfigurationLoaderProcessor.java

change the return of the getProcessIdForAudit function to a value lower than 32 characters

Modify also the code in charge of setting the Data Import Entry to Error in this case

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0055011

closed

SABARINATH P

getProcessIdForAudit for TerminalTypeUserConfigurationLoaderProcessor is returning a value higher than 32 and it fails

Notes
(0163387) hgbot (developer) 2024-04-18 13:41	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2576 [^]

(0163403) hgbot (developer) 2024-04-18 15:24	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2576 [^]

(0163404) hgbot (developer) 2024-04-18 15:24	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 2b8073c84b877dd4202be4e10b489ac628fa9bc5 Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com> Date: 18-04-2024 18:51:29 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2b8073c84b877dd4202be4e10b489ac628fa9bc5 [^] Fixed ISSUE-55237: Reduced OBPOS2_UpdateTerminalTypeUserConfiguration to 32 characters --- M src-db/database/sourcedata/AD_REF_LIST.xml M src/org/openbravo/pos2/importprocess/TerminalTypeUserConfigurationLoaderProcessor.java M src/org/openbravo/pos2/process/TerminalTypeUserConfigurationLoader.java M web-jspack/org.openbravo.pos2/src/model/setting/hooks/UpdateTerminalTypeUserConfiguration.js ---

Issue History
Date Modified	Username	Field	Change
2024-04-18 12:42	marvintm	Type	defect => backport
2024-04-18 12:42	marvintm	Target Version	=> 24Q2
2024-04-18 13:41	hgbot	Note Added: 0163387
2024-04-18 15:24	hgbot	Note Added: 0163403
2024-04-18 15:24	hgbot	Resolution	open => fixed
2024-04-18 15:24	hgbot	Status	scheduled => closed
2024-04-18 15:24	hgbot	Fixed in Version	=> 24Q2
2024-04-18 15:24	hgbot	Note Added: 0163404