Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053241 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | trivial | have not tried | 2023-08-18 15:01 | 2023-10-16 09:37 | |||
| Reporter | andre_montenegro | View Status | public | |||||
| Assigned To | andre_montenegro | |||||||
| Priority | low | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053241: Follow up and update to "eslint-plugin-cypress" version which fixes "unsave-to-chain-command" error | |||||||
| Description | After an update to 2.14.0, the cypress/unsafe-to-chain-command rule is triggered by code as: cy.focused().type("text") This should be no problem however, as the cypress document states cy.focused() is a query, and it is safe to chain further commands (https://docs.cypress.io/api/commands/focused [^]) Currently, this is an opened issue in plugin's repo: https://github.com/cypress-io/eslint-plugin-cypress/issues/140 [^] Follow up this issue and update plugin to the version which fixes it and delete the exception "eslint-disable-next-line cypress/unsafe-to-chain-command" from Cypress tests in pos2 module: - pager.spec.js - deliveryModes.js - quotation.js - ticket.js - paidReceipts.int.spec.js | |||||||
| Steps To Reproduce | By having installed "eslint-plugin-cypress" version 2.14.0, open org.openbravo.pos2/web-jspack/org.openbravo.pos2/src-test/cypress with VSCode and delete the exception "// eslint-disable-next-line cypress/unsafe-to-chain-command " for the following tests: - pager.spec.js - deliveryModes.js - quotation.js - ticket.js - paidReceipts.int.spec.js Then, from a terminal at "openbravo/" folder, execute: ./modules/org.openbravo.client.kernel/jslint/jslint Warning messages appears related with cypress chaining. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0155479) hgbot (developer) 2023-10-04 09:29 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1256 [^] |
|
(0155480) hgbot (developer) 2023-10-04 09:37 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2141 [^] |
|
(0155850) hgbot (developer) 2023-10-16 09:34 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: b0e795fa809e90b845409ad8d30171257a18d706 Author: André Montenegro <andre.montenegro@openbravo.com> Date: 04-10-2023 09:19:02 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b0e795fa809e90b845409ad8d30171257a18d706 [^] Fixes ISSUE-53241: updated eslint-plugin-cypress to latests version --- M web-jspack/org.openbravo.core2/package-lock.json M web-jspack/org.openbravo.core2/package.json --- |
|
(0155851) hgbot (developer) 2023-10-16 09:34 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1256 [^] |
|
(0155852) hgbot (developer) 2023-10-16 09:35 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 6c0d6f24df31d4c2652048a3534efd1180b31456 Author: André Montenegro <andre.montenegro@openbravo.com> Date: 16-10-2023 09:30:24 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6c0d6f24df31d4c2652048a3534efd1180b31456 [^] Fixes ISSUE-53241: deleted eslint exception on cy.focused() command --- M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/deliveryModes.spec.js M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/pager.spec.js M web-jspack/org.openbravo.pos2/src-test/cypress/functions/deliveryModes.js M web-jspack/org.openbravo.pos2/src-test/cypress/functions/quotation.js M web-jspack/org.openbravo.pos2/src-test/cypress/functions/ticket.js M web-jspack/org.openbravo.pos2/src-test/cypress/integration/paidReceipts.int.spec.js M web-jspack/org.openbravo.pos2/src-test/cypress/integration/productStock.int.spec.js --- |
|
(0155853) hgbot (developer) 2023-10-16 09:35 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2141 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-08-18 15:01 | andre_montenegro | New Issue | |
| 2023-08-18 15:01 | andre_montenegro | Assigned To | => andre_montenegro |
| 2023-08-18 15:01 | andre_montenegro | Triggers an Emergency Pack | => No |
| 2023-08-18 15:17 | andre_montenegro | Relationship added | caused by 0053197 |
| 2023-10-04 09:29 | hgbot | Note Added: 0155479 | |
| 2023-10-04 09:37 | hgbot | Note Added: 0155480 | |
| 2023-10-16 09:34 | hgbot | Resolution | open => fixed |
| 2023-10-16 09:34 | hgbot | Status | new => closed |
| 2023-10-16 09:34 | hgbot | Fixed in Version | => 24Q1 |
| 2023-10-16 09:34 | hgbot | Note Added: 0155850 | |
| 2023-10-16 09:34 | hgbot | Note Added: 0155851 | |
| 2023-10-16 09:35 | hgbot | Note Added: 0155852 | |
| 2023-10-16 09:35 | hgbot | Note Added: 0155853 | |
| 2023-10-16 09:37 | andre_montenegro | Fixed in Version | 24Q1 => |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |