Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0052925

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Retail API

major

always

2023-07-05 12:17

2023-07-12 09:22

Reporter

kchoperena

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0052925: Ship step of ExternalOrderLoader fails when there is a deleted line before an ordered line in the receipt

Description

If there is an order with the same status as the attached screenshot, the ExternalOrderLoader's ship step is failing because the filterNoDeletedLines function of ExternalOrderLoaderTransformationJsonHook class is not correctly building the noDeletedLines array

Steps To Reproduce

Create an order using WebPOS that is persisted in the database with a deleted line before an ordered line according to the lineNo order (see screenshot)

Call to the ExternalOrderLoader with the step "SHIP" to deliver only one line. Example:
{
  "messageId": "messageId",
  "posTerminal": "214101",
  "channel": "External",
  "data": [
    {
      "id": "orderId",
      "step": "ship",
      "lines": [
        {
          "id": "line1",
          "qty": 1
        }
      ]
    }
  ]
}

RESULT:
The filterNoDeletedLines will create an array with a null value and later the ExternalOrderLoader will fail processing it

Proposed Solution

When building noDeletedLines avoid the index parameter putting elements in the JSONArray

Attached a patch

Tags

No tags attached.

Screenshot from 2023-07-05 12-05-17.png [^] (159,398 bytes) 2023-07-05 12:17

issue5295.diff [^] (763 bytes) 2023-07-05 12:21 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/api/events/order/ExternalOrderLoaderTransformationJsonHook.java b/src/org/openbravo/retail/api/events/order/ExternalOrderLoaderTransformationJsonHook.java
index 24cbae7..d1eda99 100644
--- a/src/org/openbravo/retail/api/events/order/ExternalOrderLoaderTransformationJsonHook.java
+++ b/src/org/openbravo/retail/api/events/order/ExternalOrderLoaderTransformationJsonHook.java
@@ -70,7 +70,7 @@ public class ExternalOrderLoaderTransformationJsonHook
         line.put("relatedLines", line.getJSONArray("relatedProducts"));
       }
       if (line.getInt("orderedQuantity") != 0 || step.equals("update")) {
-        noDeletedLines.put(j, line);
+        noDeletedLines.put(line);
       }
       line.remove("updated");
     }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

ranjith_qualiantech_com

External Order Loader (Ship Step) finish with error

Notes
(0152229) hgbot (developer) 2023-07-10 09:38	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/73 [^]

(0152373) hgbot (developer) 2023-07-12 09:22	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/73 [^]

(0152374) hgbot (developer) 2023-07-12 09:22	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api [^] Changeset: b73f6f0a2d6e512f7e18fa7bf5706aae3fcf1a22 Author: Ranjith S R <ranjith@qualiantech.com> Date: 07-07-2023 18:23:27 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/commit/b73f6f0a2d6e512f7e18fa7bf5706aae3fcf1a22 [^] Fixed ISSUE-52925: Lines added to JSONArray without index --- M src/org/openbravo/retail/api/events/order/ExternalOrderLoaderTransformationJsonHook.java ---

Issue History
Date Modified	Username	Field	Change
2023-07-05 12:17	kchoperena	New Issue
2023-07-05 12:17	kchoperena	Assigned To	=> Triage Platform Conn
2023-07-05 12:17	kchoperena	File Added: Screenshot from 2023-07-05 12-05-17.png
2023-07-05 12:17	kchoperena	OBNetwork customer	=> Gold
2023-07-05 12:17	kchoperena	Triggers an Emergency Pack	=> No
2023-07-05 12:20	kchoperena	Proposed Solution updated
2023-07-05 12:21	kchoperena	File Added: issue5295.diff
2023-07-05 12:44	adrianromero	Assigned To	Triage Platform Conn => Retail
2023-07-07 09:27	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2023-07-07 09:27	ranjith_qualiantech_com	Status	new => scheduled
2023-07-10 09:38	hgbot	Merge Request Status	=> open
2023-07-10 09:38	hgbot	Note Added: 0152229
2023-07-12 09:22	hgbot	Merge Request Status	open => approved
2023-07-12 09:22	hgbot	Note Added: 0152373
2023-07-12 09:22	hgbot	Resolution	open => fixed
2023-07-12 09:22	hgbot	Status	scheduled => closed
2023-07-12 09:22	hgbot	Note Added: 0152374
2023-09-13 11:12	ranjith_qualiantech_com	Relationship added	related to 0053444

Copyright © 2000 - 2009 MantisBT Group