Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0052918 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [POS2] POS | minor | N/A | 2023-07-04 12:00 | 2023-12-29 09:56 | |||
Reporter | andre_montenegro | View Status | public | |||||
Assigned To | jarmendariz | |||||||
Priority | low | Resolution | fixed | Fixed in Version | 24Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0052918: Fix productSearch Cypress test structure | |||||||
Description | Functions has been defined inside spec file when they should be defined in it's respective function file. Also, review if any of the functions are already created in folders file. Avoid duplicating a function that does the same actions. | |||||||
Steps To Reproduce | Having a POS2 context, go to spec file: .../org.openbravo.core2/src-test/cypress/e2e/Features/productSearch.spec.js And notice that functions are defined in the spec file. | |||||||
Proposed Solution | Functions MUST be defined in it's respective file/folder: .../org.openbravo.core2/src-test/cypress/functions/productSearch.js Following functions must be moved to the mentioned file, reviewed and transformed into a custom Cypress command (by adding "cy." before each function name): checkProductsAreOrderedAlphabetically checkProductsAreOrderedReverseAlphabetically changeOrderingToReverseAlphabetical filterByCharacteristic assertNumberFilteredProducts | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0158683) hgbot (developer) 2023-12-28 08:59 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2314 [^] |
(0158717) hgbot (developer) 2023-12-29 09:56 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 6fdeb2733538d6bd6c3c94ed2b8861cf5146094d Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 29-12-2023 09:56:17 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6fdeb2733538d6bd6c3c94ed2b8861cf5146094d [^] Fixed ISSUE-52918: Refactored productSearch.spec test to move its functions to their respective file --- M web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/productSearch.spec.js M web-jspack/org.openbravo.pos2/src-test/cypress/functions/productSearch.js --- |
(0158718) hgbot (developer) 2023-12-29 09:56 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2314 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2023-07-04 12:00 | andre_montenegro | New Issue | |
2023-07-04 12:00 | andre_montenegro | Assigned To | => jarmendariz |
2023-07-04 12:00 | andre_montenegro | Triggers an Emergency Pack | => No |
2023-12-28 08:59 | hgbot | Note Added: 0158683 | |
2023-12-28 09:00 | jarmendariz | Status | new => scheduled |
2023-12-29 09:56 | hgbot | Resolution | open => fixed |
2023-12-29 09:56 | hgbot | Status | scheduled => closed |
2023-12-29 09:56 | hgbot | Fixed in Version | => 24Q1 |
2023-12-29 09:56 | hgbot | Note Added: 0158717 | |
2023-12-29 09:56 | hgbot | Note Added: 0158718 |
Copyright © 2000 - 2009 MantisBT Group |