Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052639
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] 01. General setupmajoralways2023-06-01 12:502024-02-29 18:03
ReporterpsanjuanView Statuspublic 
Assigned Tojamie_reid 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052639: It is required to add a unique identifier for each Tax Rate element in OB

DescriptionIt is required to add a unique identifier for each Tax Rate element in OB, this unique identifier could be a new field in the Tax Rate window named "Tax Code"
Steps To Reproducen/A
Proposed SolutionIt is required to add a unique identifier for each Tax Rate element in OB named Tax Code. This value is required to uniquely identifier an OB Tax Rate so a mapping base on it can be performed.

For the existing tax rate, this new field will be filled in with the concatenated value of “c_Tax.Name” and “C_Tax.Parent_Tax_ID”
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on feature request 0053301 closedjamie_reid Openbravo ERP API Change: Create mandatory and unique C_Tax.value column 
related to feature request 0053410 closedjonae Openbravo Localizations The TaxRate entity has a new searchKey field that has to be used as tax rate code in saft functionality 
blocks feature request 0052622 closedjamie_reid Retail Modules POS FiscaIization API - It is required to include the property “TaxG” in the JSON file for the event Ticket Complete 

-  Notes
(0151305)
psanjuan (manager)
2023-06-19 14:10

 https://openbravo.atlassian.net/browse/RM-6708 [^]
(0152492)
hgbot (developer)
2023-07-14 11:01

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/943 [^]
(0152493)
hgbot (developer)
2023-07-14 11:02

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1282 [^]
(0153622)
hgbot (developer)
2023-08-17 16:27

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/69 [^]
(0153800)
hgbot (developer)
2023-08-22 15:47

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/319 [^]
(0154010)
hgbot (developer)
2023-08-28 10:54

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5508cbd2d128293545659120c4fde0a2e9053c24
Author: Jamie Reid <jamie.reid@openbravo.com>
Date: 28-08-2023 08:54:46
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5508cbd2d128293545659120c4fde0a2e9053c24 [^]

Fixes ISSUE-52639: Unique Tax Rate Identifier field added to the backend and POS

---
M referencedata/sampledata/F_B_International_Group/C_TAX.xml
M referencedata/sampledata/QA_Testing/C_TAX.xml
M src-db/database/model/tables/C_TAX.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0154011)
hgbot (developer)
2023-08-28 10:54

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/943 [^]
(0154014)
hgbot (developer)
2023-08-28 10:56

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4aeb62e4dc39edd4f2d60520fa4b3f2bae39f399
Author: Jamie Reid <jamie.reid@openbravo.com>
Date: 28-08-2023 08:56:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4aeb62e4dc39edd4f2d60520fa4b3f2bae39f399 [^]

Fixes ISSUE-52639: Unique Tax Rate Identifier field added to the backend and POS

---
M src/org/openbravo/retail/posterminal/InvoiceTaxesProperties.java
M src/org/openbravo/retail/posterminal/Invoices.java
M src/org/openbravo/retail/posterminal/PaidReceiptLineTaxesProperties.java
M src/org/openbravo/retail/posterminal/PaidReceiptTaxesProperties.java
M src/org/openbravo/retail/posterminal/master/TaxRateProperties.java
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/interface/tax-posinterface.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
---
(0154015)
hgbot (developer)
2023-08-28 10:56

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1282 [^]
(0154016)
hgbot (developer)
2023-08-28 10:57

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 04e74a1db3c397833f46ba62a80d49c19c810741
Author: Jamie Reid <jamie.reid@openbravo.com>
Date: 28-08-2023 08:57:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/04e74a1db3c397833f46ba62a80d49c19c810741 [^]

Relates to ISSUE-52639: sets sampledata suggested by run try

---
M referencedata/sampledata/The_White_Valley_Group/AD_SEQUENCE.xml
M referencedata/sampledata/The_White_Valley_Group/C_TAX.xml
---
(0154017)
hgbot (developer)
2023-08-28 10:57

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/69 [^]
(0154018)
hgbot (developer)
2023-08-28 10:57

 Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/319 [^]
(0154019)
hgbot (developer)
2023-08-28 10:57

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: d59f97582aa51ef1d851e7df43985d7ca1eceb44
Author: Jamie Alexander Reid <jamie.reid@openbravo.com>
Date: 25-08-2023 11:55:34
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/d59f97582aa51ef1d851e7df43985d7ca1eceb44 [^]

Relates to ISSUE-52639: Change selenium test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/taxes/I36530_VerifyOldTicketsShownWithProperTaxes.java
---
(0154020)
hgbot (developer)
2023-08-28 11:03

 Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: e82ef49eeb3cac02b2840b04a3fd9efcfcbc4ed3
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 28-08-2023 11:03:39
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/e82ef49eeb3cac02b2840b04a3fd9efcfcbc4ed3 [^]

Relates to ISSUE-52639: sets sampledata suggested by run try

---
M referencedata/sampledata/The_White_Valley_Group/AD_SEQUENCE.xml
M referencedata/sampledata/The_White_Valley_Group/C_TAX.xml
---
(0154021)
hgbot (developer)
2023-08-28 11:04

 Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 93dc3127c55862997c0a4fab21e6f1188ce65d5f
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 28-08-2023 11:04:29
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/93dc3127c55862997c0a4fab21e6f1188ce65d5f [^]

Relates to ISSUE-52639: sets sampledata suggested by run try

---
M referencedata/sampledata/Retail_Test/AD_SEQUENCE.xml
M referencedata/sampledata/Retail_Test/C_TAX.xml
---
(0154164)
hgbot (developer)
2023-08-30 08:04

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sap.ecc.mappings/-/merge_requests/10 [^]
(0154176)
hgbot (developer)
2023-08-30 10:26

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sap.ecc.mappings [^]
Changeset: 534a6bb8c038152ec84509b73b16e9af7fff88b5
Author: Jamie Reid <jamie.reid@openbravo.com>
Date: 30-08-2023 08:26:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sap.ecc.mappings/-/commit/534a6bb8c038152ec84509b73b16e9af7fff88b5 [^]

Relates to ISSUE-52639: add searchKey property to TaxRate entity mapping in SAP

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0154177)
hgbot (developer)
2023-08-30 10:26

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sap.ecc.mappings/-/merge_requests/10 [^]
(0160159)
ngarcia (developer)
2024-02-02 12:49

 The search key of a tax rate is currently unique with the following four columns:

Value
Client
Organization
Parent Tax Rate

So it is still possible to have two tax rates with the same search key within the same organization if the parent tax rate is null in at least one of them or both (as it is not a mandatory field)
(0161455)
hgbot (developer)
2024-02-29 18:03

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.localization.spain.referencedata.taxes [^]
Changeset: 4289efd02360654a2f93adb6f74c9be099faa3b4
Author: Ruben Rafael Danielle <ruben.danielle@smfconsulting.es>
Date: 02-02-2024 15:15:34
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.localization.spain.referencedata.taxes/-/commit/4289efd02360654a2f93adb6f74c9be099faa3b4 [^]

Fixed ISSUE-52639: Add missing searchKey column data to TaxRate dataset elements

---
M referencedata/standard/Impuestos_ES.xml
M src-db/database/sourcedata/AD_DATASET.xml
M src-db/database/sourcedata/AD_MODULE.xml
---

- Issue History
Date Modified Username Field Change
2023-06-01 12:50 psanjuan New Issue
2023-06-01 12:50 psanjuan Assigned To => Triage Omni OMS
2023-06-01 12:50 psanjuan Modules => Core
2023-06-01 12:50 psanjuan Triggers an Emergency Pack => No
2023-06-01 12:51 psanjuan Relationship added blocks 0052621
2023-06-01 12:52 psanjuan Relationship deleted blocks 0052621
2023-06-01 12:53 psanjuan Relationship added blocks 0052622
2023-06-01 13:43 psanjuan Assigned To Triage Omni OMS => psanjuan
2023-06-01 13:43 psanjuan Type defect => feature request
2023-06-01 13:43 psanjuan Summary It is required to add a unique identifier (search Key or value) for the Tax Rate element in OB => It is required to add a unique identifier for each Tax Rate element in OB
2023-06-01 13:43 psanjuan Description Updated View Revisions
2023-06-01 13:43 psanjuan Proposed Solution updated
2023-06-19 14:09 psanjuan Proposed Solution updated
2023-06-19 14:10 psanjuan Proposed Solution updated
2023-06-19 14:10 psanjuan Note Added: 0151305
2023-07-07 13:24 hgbot Note Added: 0152194
2023-07-07 13:53 hgbot Note Added: 0152195
2023-07-13 11:01 hgbot Note Added: 0152436
2023-07-13 11:07 hgbot Note Added: 0152437
2023-07-13 11:17 hgbot Note Added: 0152438
2023-07-13 11:17 hgbot Note Added: 0152439
2023-07-13 12:35 hgbot Note Added: 0152446
2023-07-13 12:36 hgbot Note Added: 0152447
2023-07-14 11:01 hgbot Note Added: 0152492
2023-07-14 11:02 hgbot Note Added: 0152493
2023-07-27 13:07 hgbot Resolution open => fixed
2023-07-27 13:07 hgbot Status new => resolved
2023-07-27 13:07 hgbot Fixed in Version => RR23Q4
2023-07-27 13:07 hgbot Note Added: 0152930
2023-07-27 13:30 hgbot Note Added: 0152938
2023-07-27 13:40 hgbot Note Added: 0152941
2023-07-28 09:07 aferraz Assigned To psanjuan => jamie_reid
2023-07-28 09:07 aferraz Status resolved => new
2023-07-28 09:07 aferraz Resolution fixed => open
2023-07-28 09:07 aferraz Fixed in Version RR23Q4 =>
2023-07-31 09:30 hgbot Note Added: 0152992
2023-07-31 09:34 hgbot Note Added: 0152994
2023-07-31 09:36 hgbot Note Added: 0152995
2023-07-31 09:36 hgbot Note Added: 0152996
2023-07-31 09:37 hgbot Note Added: 0152997
2023-07-31 09:37 hgbot Note Added: 0152998
2023-07-31 09:38 hgbot Note Added: 0152999
2023-07-31 10:26 hgbot Note Added: 0153000
2023-07-31 10:26 hgbot Note Added: 0153001
2023-08-01 10:25 hgbot Note Added: 0153052
2023-08-16 11:34 hgbot Note Added: 0153529
2023-08-17 14:03 hgbot Note Added: 0153596
2023-08-17 14:10 hgbot Note Added: 0153598
2023-08-17 14:11 hgbot Note Added: 0153599
2023-08-17 14:11 hgbot Note Added: 0153600
2023-08-17 14:12 hgbot Note Added: 0153601
2023-08-17 14:12 hgbot Note Added: 0153604
2023-08-17 14:25 hgbot Note Added: 0153605
2023-08-17 14:26 hgbot Note Added: 0153606
2023-08-17 16:27 hgbot Note Added: 0153622
2023-08-17 17:04 hgbot Note Added: 0153623
2023-08-17 17:05 hgbot Note Added: 0153624
2023-08-18 12:44 aferraz Note Deleted: 0152194
2023-08-18 12:44 aferraz Note Deleted: 0152195
2023-08-18 12:44 aferraz Note Deleted: 0152436
2023-08-18 12:44 aferraz Note Deleted: 0152437
2023-08-18 12:44 aferraz Note Deleted: 0152438
2023-08-18 12:44 aferraz Note Deleted: 0152439
2023-08-18 12:44 aferraz Note Deleted: 0152446
2023-08-18 12:45 aferraz Note Deleted: 0152447
2023-08-18 12:45 aferraz Note Deleted: 0152930
2023-08-18 12:45 aferraz Note Deleted: 0152938
2023-08-18 12:45 aferraz Note Deleted: 0152941
2023-08-18 12:45 aferraz Note Deleted: 0152992
2023-08-18 12:47 aferraz Note Deleted: 0152996
2023-08-18 12:47 aferraz Note Deleted: 0152995
2023-08-18 12:48 aferraz Note Deleted: 0152997
2023-08-18 12:48 aferraz Note Deleted: 0152998
2023-08-18 12:48 aferraz Note Deleted: 0152999
2023-08-18 12:48 aferraz Note Deleted: 0153000
2023-08-18 12:49 aferraz Note Deleted: 0153001
2023-08-18 12:49 aferraz Note Deleted: 0153052
2023-08-18 12:49 aferraz Note Deleted: 0153529
2023-08-18 12:49 aferraz Note Deleted: 0153596
2023-08-18 12:49 aferraz Note Deleted: 0153623
2023-08-18 12:51 aferraz Note Deleted: 0153606
2023-08-18 12:52 aferraz Note Deleted: 0153605
2023-08-18 12:52 aferraz Note Deleted: 0153601
2023-08-18 12:52 aferraz Note Deleted: 0153604
2023-08-18 12:53 aferraz Note Deleted: 0153598
2023-08-18 12:53 aferraz Note Deleted: 0153599
2023-08-18 12:53 aferraz Note Deleted: 0153600
2023-08-22 15:47 hgbot Note Added: 0153800
2023-08-28 10:43 aferraz Issue cloned 0053301
2023-08-28 10:53 aferraz Relationship added depends on 0053301
2023-08-28 10:54 hgbot Resolution open => fixed
2023-08-28 10:54 hgbot Status new => closed
2023-08-28 10:54 hgbot Fixed in Version => PR23Q4
2023-08-28 10:54 hgbot Note Added: 0154010
2023-08-28 10:54 hgbot Note Added: 0154011
2023-08-28 10:56 hgbot Fixed in Version PR23Q4 => RR23Q4
2023-08-28 10:56 hgbot Note Added: 0154014
2023-08-28 10:56 hgbot Note Added: 0154015
2023-08-28 10:57 hgbot Note Added: 0154016
2023-08-28 10:57 hgbot Note Added: 0154017
2023-08-28 10:57 hgbot Note Added: 0154018
2023-08-28 10:57 hgbot Note Added: 0154019
2023-08-28 11:03 hgbot Note Added: 0154020
2023-08-28 11:04 hgbot Note Added: 0154021
2023-08-28 11:04 hgbot Note Added: 0154022
2023-08-28 11:04 hgbot Note Added: 0154024
2023-08-28 11:05 aferraz Note Deleted: 0152994
2023-08-28 11:05 aferraz Note Deleted: 0153624
2023-08-28 11:05 aferraz Note Deleted: 0154022
2023-08-28 11:05 aferraz Note Deleted: 0154024
2023-08-30 08:04 hgbot Note Added: 0154164
2023-08-30 10:26 hgbot Note Added: 0154176
2023-08-30 10:26 hgbot Note Added: 0154177
2023-09-07 11:00 jonae Relationship added related to 0053410
2024-02-02 12:49 ngarcia Note Added: 0160159
2024-02-29 18:03 hgbot Note Added: 0161455

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker