Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0051795
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2023-03-07 17:532023-04-20 12:06
ReporternoemierousselView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR23Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051795: When "Apply only once" is uncheck, it is possible to add gift endlessly

DescriptionWhen "Apply only once" is uncheck, it is possible to add gift endlessly
Steps To Reproduce1. Go to the Backoffice.

2. Go to the "Discounts and Promotion" window and create a new record.

3. Select the discount type "Buy X and get Y as gift".

4. Select the subtype "Any X Any Y" and set Min X=1, Min Y=1, Max Y=1, and add the X and Y product.

5. Uncheck the box "Apply only once".

6. In the "POS Configuration", check the "Gift reminder notification" and set the application method to automatic.

7. Repete the same creation of promo with the exact same steps than steps 1-6.

8. Go to the POS and add the eligible products to trigger the promotion.

9. Add manually the gift three times: See that it is added endlessly.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0051879 closedranjith_qualiantech_com [Promo] - Buy X Get Y - Number of gifts is multiplied by number of eligible products bought even if Max Y = 1 

-  Notes
(0148188)
ranjith_qualiantech_com (developer)
2023-04-03 11:29
edited on: 2023-04-20 11:14

Issue will not reproduced if "Apply Next Discount/Promotion" is unchecked for discounts

(0148342)
hgbot (developer)
2023-04-10 07:19

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/98 [^]
(0148627)
hgbot (developer)
2023-04-20 12:06

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/98 [^]
(0148628)
hgbot (developer)
2023-04-20 12:06

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 8275db1798042399322e462e26995a049d7d17e8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 09-04-2023 12:55:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/8275db1798042399322e462e26995a049d7d17e8 [^]

Fixed ISSUE-51795: Discount amt should not exceed line gross amount
* When adding BuyYGiftY discount, Discount amt should not exceed line gross amount
  Hidden discount should not be added, when gift discount is not added

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---

- Issue History
Date Modified Username Field Change
2023-03-07 17:53 noemieroussel New Issue
2023-03-07 17:53 noemieroussel Assigned To => Retail
2023-03-07 17:53 noemieroussel Triggers an Emergency Pack => No
2023-03-08 09:29 noemieroussel Steps to Reproduce Updated View Revisions
2023-03-24 06:37 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2023-03-24 06:37 ranjith_qualiantech_com Status new => scheduled
2023-03-30 11:16 ranjith_qualiantech_com Relationship added related to 0051879
2023-04-03 11:29 ranjith_qualiantech_com Note Added: 0148188
2023-04-03 11:29 ranjith_qualiantech_com Status scheduled => feedback
2023-04-04 07:31 ranjith_qualiantech_com Status feedback => scheduled
2023-04-09 09:44 ranjith_qualiantech_com Note Edited: 0148188 View Revisions
2023-04-10 07:19 hgbot Note Added: 0148342
2023-04-20 11:14 ranjith_qualiantech_com Note Edited: 0148188 View Revisions
2023-04-20 12:06 hgbot Resolution open => fixed
2023-04-20 12:06 hgbot Status scheduled => closed
2023-04-20 12:06 hgbot Note Added: 0148627
2023-04-20 12:06 hgbot Fixed in Version => RR23Q3
2023-04-20 12:06 hgbot Note Added: 0148628


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker