Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050763
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSmajorhave not tried2022-11-03 23:412022-11-07 18:11
ReporterAugustoMauchView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in Version22Q3.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q3.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050763: Memory leak in Carousel.jsx - DOM event listeners are not being removed

DescriptionThe Carousel.jsx component has a memory leak because it is registering DOM events on a useEffect hook but is never unregistering them.

The useEffect hook should return a function that will be invoked when unmounting the component and that will unregister the DOM events
Steps To ReproduceSee the code here [1], it is adding two event listeners but never removing them. It should removee them like it is done here [2]

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/Carousel/Carousel.jsx#L66 [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/DrawerMenu/DrawerMenuGroup.jsx#L250 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0050727 closedRetail Memory leak in Carousel.jsx - DOM event listeners are not being removed 

-  Notes
(0143178)
hgbot (developer)
2022-11-07 17:25

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/894 [^]
(0143181)
hgbot (developer)
2022-11-07 17:47

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/894 [^]
(0143182)
hgbot (developer)
2022-11-07 17:47

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 4bc75477f809277cbf60a12b2ba9822cfbf60c23
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 07-11-2022 17:24:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/4bc75477f809277cbf60a12b2ba9822cfbf60c23 [^]

Fixes ISSUE-50763: Avoids memory leak in Carousel.jsx by unregistering event listeners

---
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/hooks/usePagination.js
M web-jspack/org.openbravo.core2/src/components/Carousel/Carousel.jsx
---
(0143183)
hgbot (developer)
2022-11-07 18:02

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1344 [^]
(0143184)
hgbot (developer)
2022-11-07 18:11

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 97327888039bae3a9e88978a66906d71b53f3bd1
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 07-11-2022 18:01:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/97327888039bae3a9e88978a66906d71b53f3bd1 [^]

Related to ISSUE-50763: Fixing potential memory leakon resize event

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/ProductButtonContent.jsx
---
(0143185)
hgbot (developer)
2022-11-07 18:11

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1344 [^]

- Issue History
Date Modified Username Field Change
2022-11-07 16:00 guilleaer Type defect => backport
2022-11-07 16:00 guilleaer Target Version => 22Q3.3
2022-11-07 17:25 hgbot Note Added: 0143178
2022-11-07 17:47 hgbot Merge Request Status open => approved
2022-11-07 17:47 hgbot Resolution open => fixed
2022-11-07 17:47 hgbot Status scheduled => closed
2022-11-07 17:47 hgbot Note Added: 0143181
2022-11-07 17:47 hgbot Fixed in Version => 22Q3.2
2022-11-07 17:47 hgbot Note Added: 0143182
2022-11-07 18:02 hgbot Note Added: 0143183
2022-11-07 18:11 hgbot Note Added: 0143184
2022-11-07 18:11 hgbot Note Added: 0143185

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker