Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050626 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] Core | critical | have not tried | 2022-10-25 11:39 | 2022-10-26 19:17 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | yogaskarnik | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | cberner | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050626: Autocomplete CRM reference properties are not supported for discounts & promotions property/condition | |||||||
| Description | Autocomplete is a new CRM reference type that was added in core2, but it is not supported to be used as a CRM Property Condition in the Discounts & Promotions window. Related issue, where Autocomplete CRM type reference is introduced: https://issues.openbravo.com/view.php?id=49834 [^] | |||||||
| Steps To Reproduce | This should be reproducible in an environment with pos2-modules 1. Login Backoffice and configure a CRM property as Autocomplete reference 2. Go to Discounts&Promotions and add that crm property on one discount in the subtab CRM Property Condition 3. Login WebPOS and refresh masterdata 4. Try to add a product with that particular discount 5. Change Business Partner to some business partner from the CRM | |||||||
| Proposed Solution | As system admin, in Comparators window, add Autocomplete reference type as a Supported reference to the same comparators that have String reference as supported. Create a new file, following the logic of StringComparatorType.js: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/blob/master/web/org.openbravo.discounts.propertycondition/js/engine/comparators/StringComparatorType.js [^] This should contain the functions for each of the supported comparisons of the Autocomplete reference type. Make sure this is executed as part of the ob-init.js or before. | |||||||
| Tags | FASH | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0142606) hgbot (developer) 2022-10-26 17:18 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/17 [^] |
|
(0142624) hgbot (developer) 2022-10-26 19:16 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/17 [^] |
|
(0142625) hgbot (developer) 2022-10-26 19:16 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^] Changeset: a3a3ac4dba6b9ba326105c6cae003ba825354aa1 Author: Yogas Karnik <yogas.karnik@openbravo.com> Date: 26-10-2022 17:16:44 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/a3a3ac4dba6b9ba326105c6cae003ba825354aa1 [^] Fixes FR-50626: Autocomplete CRM reference properties are not supported for autocomplete Adds support for Autocomplete core2 CRM reference property, by adding the necessary comparators. It also adds a test for it, and the necessary Supported References for this new comparator. --- A src-test/org/openbravo/discounts/propertycondition/comparators/AutocompleteComparatorTypeTest.java A web/org.openbravo.discounts.propertycondition/js/engine/comparators/AutocompleteComparatorType.js M src-db/database/sourcedata/OBPRDIS_REF_COMPARATOR.xml M src-test/org/openbravo/discounts/propertycondition/DiscountsPropertyConditionTestSuite.java M src/org/openbravo/discounts/propertycondition/DiscountsPropertyConditionComponentProvider.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-10-25 11:39 | cberner | New Issue | |
| 2022-10-25 11:39 | cberner | Assigned To | => Triage Platform Base |
| 2022-10-25 11:39 | cberner | Triggers an Emergency Pack | => No |
| 2022-10-25 11:51 | rafaroda | Tag Attached: FASH | |
| 2022-10-25 11:52 | rafaroda | Severity | major => critical |
| 2022-10-25 14:20 | alostale | Relationship added | related to 0049834 |
| 2022-10-25 14:25 | alostale | Assigned To | Triage Platform Base => yogaskarnik |
| 2022-10-25 15:49 | rafaroda | Relationship added | related to 0050629 |
| 2022-10-26 17:18 | hgbot | Note Added: 0142606 | |
| 2022-10-26 19:16 | hgbot | Note Added: 0142624 | |
| 2022-10-26 19:16 | hgbot | Resolution | open => fixed |
| 2022-10-26 19:16 | hgbot | Status | new => resolved |
| 2022-10-26 19:16 | hgbot | Note Added: 0142625 | |
| 2022-10-26 19:17 | cberner | Review Assigned To | => cberner |
| 2022-10-26 19:17 | cberner | Status | resolved => closed |
| 2022-10-26 19:17 | cberner | Fixed in Version | => 23Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |