Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050368 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Openbravo Business API | minor | have not tried | 2022-09-28 15:28 | 2022-10-11 10:48 | |||
| Reporter | ignacio_deandres | View Status | public | |||||
| Assigned To | ignacio_deandres | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0050368: Code improvements required in some classes in the business API | |||||||
| Description | There are event handlers that should be repackaged and their classes should not be public. These classes should be in the "dal" package, alongside the other event handlers. There are classes that implement the ImportedBaseOBObjectFetcher interface. These classes should return a concrete object type, and not a generic one. There is some code that could be refactored. | |||||||
| Steps To Reproduce | No need to reproduce as it is just code clean up. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0141447) hgbot (developer) 2022-09-28 15:46 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/89 [^] |
|
(0141920) hgbot (developer) 2022-10-10 15:47 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/89 [^] |
|
(0141921) hgbot (developer) 2022-10-10 15:47 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: 073f8806d72f695e16806d3a6ba5f26e7dd085ed Author: ignacio.deandres <ignacio.deandres@openbravo.com> Date: 10-10-2022 13:34:55 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/073f8806d72f695e16806d3a6ba5f26e7dd085ed [^] Fixes ISSUE-50368: code improvements - EntityPersistenceEventObservers do not need to be public and also have been repackaged - Use class instead of generic class in ImportedBaseOBObjectFetcher --- A src/org/openbravo/api/dal/goodsmovement/GoodsMvmtLinesEventHandler.java A src/org/openbravo/api/dal/inventory/InventoryLinesEventHandler.java M src/org/openbravo/api/hook/goodsmovement/ImportGoodsMvmtBaseOBObjectFetcher.java M src/org/openbravo/api/hook/inventory/ImportInventoryBaseOBObjectFetcher.java M src/org/openbravo/api/hook/user/ImportedUserRolesBaseOBObjectFetcher.java --- |
|
(0141949) hgbot (developer) 2022-10-11 10:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: 480da79b3ee5f8237f73989cc65836d41798a75a Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 11-10-2022 10:44:55 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/480da79b3ee5f8237f73989cc65836d41798a75a [^] related to ISSUE-50368: revert changes done in ImportedBaseOBObjectFetchers The changes to improve the ImportedBaseOBObjectFetchers code forced us to include a @SuppressWarnings("unchecked") at class level to avoid warning errors when compiling through the console. As in general we do not want to skip this check for an entire class, we are just reverting the changes done at the fetch method declaration for those classes. --- M src/org/openbravo/api/hook/goodsmovement/ImportGoodsMvmtBaseOBObjectFetcher.java M src/org/openbravo/api/hook/inventory/ImportInventoryBaseOBObjectFetcher.java M src/org/openbravo/api/hook/user/ImportedUserRolesBaseOBObjectFetcher.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-09-28 15:28 | ignacio_deandres | New Issue | |
| 2022-09-28 15:28 | ignacio_deandres | Assigned To | => ignacio_deandres |
| 2022-09-28 15:46 | hgbot | Note Added: 0141447 | |
| 2022-09-29 13:01 | ignacio_deandres | Description Updated | View Revisions |
| 2022-10-10 15:46 | caristu | Relationship added | related to 0044131 |
| 2022-10-10 15:47 | hgbot | Note Added: 0141920 | |
| 2022-10-10 15:47 | hgbot | Resolution | open => fixed |
| 2022-10-10 15:47 | hgbot | Status | new => closed |
| 2022-10-10 15:47 | hgbot | Note Added: 0141921 | |
| 2022-10-11 10:48 | hgbot | Note Added: 0141949 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |