Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049513
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorN/A2022-06-08 18:022022-06-17 13:55
Reportergorka_gilView Statuspublic 
Assigned Togorka_gil 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049513: All filters from a filterable grid should be able to be reset

DescriptionThere is two cases:
- the combo filters, once a value is set, when selecting the empty option it is filtering by null instead of remove the filter.
- the selector filter like the customer selector if missing a way to clear its filter, probably add an X to reset it. Also when deleting the value, should not send an filter by null, but remove the filter in the query.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0049095 closedgorka_gil Show the customer activity 
related to defect 0049123 closedgorka_gil Removing a filter in order selector doesn't reset the filter 

-  Notes
(0138377)
hgbot (developer)
2022-06-15 16:15

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/772 [^]
(0138378)
hgbot (developer)
2022-06-15 16:19

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1010 [^]
(0138494)
hgbot (developer)
2022-06-17 13:53

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 933cd0b96121f16a0a0e3f5dcfa2c45fe7ab58b8
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/933cd0b96121f16a0a0e3f5dcfa2c45fe7ab58b8 [^]

Fixes ISSUE-49513: When resetting a filter, stop taking it into account in the filtering

---
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterBar.jsx
---
(0138495)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 4f7f8a28be07953d029dbc937eb587fe9efc0da7
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/4f7f8a28be07953d029dbc937eb587fe9efc0da7 [^]

Related to ISSUE-49513: Add BaseFormSelector

---
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.jsx
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.scss
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/ClearSelectorButton.jsx
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/ClearSelectorButton.scss
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/index.js
---
(0138496)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: ef4e80bae9391380fd82e29a851648f0b9dc0f61
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ef4e80bae9391380fd82e29a851648f0b9dc0f61 [^]

Related to ISSUE-49513: Add BaseForSelector to take the styles inside a filter bar

---
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterInputRender.scss
---
(0138497)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: d5dd5665188f32a70df9e0721183e0f9a9fcec47
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/d5dd5665188f32a70df9e0721183e0f9a9fcec47 [^]

Related to ISSUE-49513: when readonly do not open the selector

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.jsx
---
(0138498)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 2316c9cc0f14e23f922f717a922c30edec4ca2f8
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/2316c9cc0f14e23f922f717a922c30edec4ca2f8 [^]

Related to ISSUE-49513: inherit styles of BaseFormSelector to avoid duplicate styles

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.scss
---
(0138499)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 479a8456862d0d1ffeb2be7996c53e7be0d0db5e
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/479a8456862d0d1ffeb2be7996c53e7be0d0db5e [^]

Related to ISSUE-49513: Add serach icon to the selector button

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.scss
---
(0138500)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 3e949fcb26594cc4fe824caab74693ab3ba19095
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3e949fcb26594cc4fe824caab74693ab3ba19095 [^]

Related to ISSUE-49513: open the popup on space and enter press

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.jsx
---
(0138501)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 90ea8733caf1898be28ecd44be1aac63dcb0f976
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/90ea8733caf1898be28ecd44be1aac63dcb0f976 [^]

Related to ISSUE-49513: Add tests and stories

---
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/__test__/BaseFormSelector.test.jsx
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/__test__/clearInput.js
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/__test__/fillInput.js
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/stories/BaseFormSelector.stories.jsx
A web-jspack/org.openbravo.core2/src/components/BaseFormSelector/stories/BaseFormSelector.stories.scss
---
(0138502)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 6a89c2cd1dfe6d1439b555d13cc0d4f249134ae2
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 20:04:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6a89c2cd1dfe6d1439b555d13cc0d4f249134ae2 [^]

Related to ISSUE-49513: add ellipsis and reduce padding from the input to the X

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.scss
---
(0138503)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: d931d8cd056276c67f14c655d712cbda9a27fa65
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 12:18:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/d931d8cd056276c67f14c655d712cbda9a27fa65 [^]

Related to ISSUE-49513: don't allow to select and fix pointer

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.scss
---
(0138504)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c9a61fcbebd79c7741772eb538f7fa0b94653e1a
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 12:28:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c9a61fcbebd79c7741772eb538f7fa0b94653e1a [^]

Related to ISSUE-49513: delete the selector on delete and backspace

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.jsx
---
(0138505)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c292da2d6a406c41bbfe50211578e790bf64a541
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:34:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c292da2d6a406c41bbfe50211578e790bf64a541 [^]

Related to ISSUE-49513: Fix styles of the search icon in selector

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.scss
---
(0138506)
hgbot (developer)
2022-06-17 13:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: da5ebeed817c025823641828e74487971c17776d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:47:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/da5ebeed817c025823641828e74487971c17776d [^]

Related to ISSUE-49513: Decrease the margin between the input and the X

---
M web-jspack/org.openbravo.core2/src/components/BaseFormSelector/BaseFormSelector.scss
---
(0138507)
hgbot (developer)
2022-06-17 13:53

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/772 [^]
(0138508)
hgbot (developer)
2022-06-17 13:55

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7acf3e7efd66f7630e655116ef47bb328be22b83
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:53:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7acf3e7efd66f7630e655116ef47bb328be22b83 [^]

Related to ISSUE-49513: Display and X to allow reset bp filter button

---
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridBPFilter.jsx
---
(0138509)
hgbot (developer)
2022-06-17 13:55

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 04175448d0e6c4e82e7e9a3feaaf442041ba530f
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:53:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/04175448d0e6c4e82e7e9a3feaaf442041ba530f [^]

Related to ISSUE-49513: Use BaseFormSelector in TicketListRemoteGridBPFilter

---
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridBPFilter.jsx
---
(0138510)
hgbot (developer)
2022-06-17 13:55

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 02ed8d35f452e64cb93d9dffab17ad6d01d7c149
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:53:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/02ed8d35f452e64cb93d9dffab17ad6d01d7c149 [^]

Related to ISSUE-49513: rename registered component OBPOS2_BusinessPartnerFilter to OBPOS2_TicketListRemoteGridBPFilter

---
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGrid.config.json
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0138511)
hgbot (developer)
2022-06-17 13:55

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c89a1068efea0b65da04a466112b7d3438998b3d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:53:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c89a1068efea0b65da04a466112b7d3438998b3d [^]

Related to ISSUE-49513: remove styles not needed

---
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridBPFilter.scss
---
(0138512)
hgbot (developer)
2022-06-17 13:55

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 04992f8aebe6c9d710dfc7c281a57d2ccefabf9e
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:53:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/04992f8aebe6c9d710dfc7c281a57d2ccefabf9e [^]

Related to ISSUE-49513: Fix tests

---
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGridBPFilter.test.jsx
---
(0138513)
hgbot (developer)
2022-06-17 13:55

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7bdfa5ab38c6f702be76811421563c66adf52e17
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 17-06-2022 13:53:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7bdfa5ab38c6f702be76811421563c66adf52e17 [^]

Related to ISSUE-49513: Fix cypress test

---
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/viewOrdersOfCustomer.spec.js
---
(0138514)
hgbot (developer)
2022-06-17 13:55

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1010 [^]

- Issue History
Date Modified Username Field Change
2022-06-08 18:02 gorka_gil New Issue
2022-06-08 18:02 gorka_gil Assigned To => Retail
2022-06-08 18:02 gorka_gil OBNetwork customer => No
2022-06-08 18:02 gorka_gil Triggers an Emergency Pack => No
2022-06-08 18:03 gorka_gil Relationship added related to 0049095
2022-06-08 18:03 gorka_gil Relationship added related to 0049123
2022-06-08 18:06 gorka_gil Relationship added related to 0049514
2022-06-08 18:07 gorka_gil Relationship deleted related to 0049514
2022-06-13 18:38 gorka_gil Assigned To Retail => gorka_gil
2022-06-15 16:15 hgbot Merge Request Status => open
2022-06-15 16:15 hgbot Note Added: 0138377
2022-06-15 16:19 hgbot Note Added: 0138378
2022-06-17 12:44 hgbot Merge Request Status open => approved
2022-06-17 13:53 hgbot Resolution open => fixed
2022-06-17 13:53 hgbot Status new => closed
2022-06-17 13:53 hgbot Note Added: 0138494
2022-06-17 13:53 hgbot Note Added: 0138495
2022-06-17 13:53 hgbot Note Added: 0138496
2022-06-17 13:53 hgbot Note Added: 0138497
2022-06-17 13:53 hgbot Note Added: 0138498
2022-06-17 13:53 hgbot Note Added: 0138499
2022-06-17 13:53 hgbot Note Added: 0138500
2022-06-17 13:53 hgbot Note Added: 0138501
2022-06-17 13:53 hgbot Note Added: 0138502
2022-06-17 13:53 hgbot Note Added: 0138503
2022-06-17 13:53 hgbot Note Added: 0138504
2022-06-17 13:53 hgbot Note Added: 0138505
2022-06-17 13:53 hgbot Note Added: 0138506
2022-06-17 13:53 hgbot Note Added: 0138507
2022-06-17 13:55 hgbot Note Added: 0138508
2022-06-17 13:55 hgbot Note Added: 0138509
2022-06-17 13:55 hgbot Note Added: 0138510
2022-06-17 13:55 hgbot Note Added: 0138511
2022-06-17 13:55 hgbot Note Added: 0138512
2022-06-17 13:55 hgbot Note Added: 0138513
2022-06-17 13:55 hgbot Note Added: 0138514

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker