Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049090 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-04-20 08:55 | 2022-04-20 10:39 | |||
| Reporter | ebecerra | View Status | public | |||||
| Assigned To | ebecerra | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049090: Restaurant: Function "getRestaurantService" fail when service time is before 10:00 AM | |||||||
| Description | When calls the function "getRestaurantService" before 10:00 AM always return "false". | |||||||
| Steps To Reproduce | 1. In the BO configure a mealservice to start at: 01:00:00 2. In the BO configure another mealservice to start at: 10:30:00 3. Call the function "getRestaurantService" with argument time before 10:30 PM | |||||||
| Proposed Solution | Fixes in the file: GetRestaurantService.js the function: isValidHour function isValidHour(hour, dayStartTime) { let serviceStartTime = new Date(dayStartTime).toLocaleTimeString(); if (serviceStartTime.length < 8) { serviceStartTime = `0${serviceStartTime}`; } return hour >= serviceStartTime; } | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0136618) hgbot (developer) 2022-04-20 09:50 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/135 [^] |
|
(0136621) hgbot (developer) 2022-04-20 10:39 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: 7cba4dd21450f1566e88725919720c79c306439f Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com> Date: 20-04-2022 08:39:40 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/7cba4dd21450f1566e88725919720c79c306439f [^] Fixes ISSUE-49090: Restaurant: Function "getRestaurantService" fail when... --- M web-jspack/org.openbravo.pos2.restaurant/src/model/meal-service/GetRestaurantService.js --- |
|
(0136622) hgbot (developer) 2022-04-20 10:39 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/135 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-04-20 08:55 | ebecerra | New Issue | |
| 2022-04-20 08:55 | ebecerra | Assigned To | => Retail |
| 2022-04-20 08:55 | ebecerra | Triggers an Emergency Pack | => No |
| 2022-04-20 09:03 | ebecerra | Summary | Restaurant: Function "getRestaurantService" fail when time is before 10:00 AM => Restaurant: Function "getRestaurantService" fail when service time is before 10:00 AM |
| 2022-04-20 09:03 | ebecerra | Steps to Reproduce Updated | View Revisions |
| 2022-04-20 09:03 | ebecerra | Proposed Solution updated | |
| 2022-04-20 09:12 | ebecerra | Proposed Solution updated | |
| 2022-04-20 09:12 | ebecerra | Assigned To | Retail => ebecerra |
| 2022-04-20 09:12 | ebecerra | Status | new => scheduled |
| 2022-04-20 09:50 | hgbot | Note Added: 0136618 | |
| 2022-04-20 10:39 | hgbot | Resolution | open => fixed |
| 2022-04-20 10:39 | hgbot | Status | scheduled => closed |
| 2022-04-20 10:39 | hgbot | Note Added: 0136621 | |
| 2022-04-20 10:39 | hgbot | Note Added: 0136622 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |