Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0046794

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

feature request

[Openbravo ERP] A. Platform

major

always

2021-05-21 18:30

2021-05-26 11:06

Reporter

rtoledano

View Status

public

Assigned To

rtoledano

Priority

urgent

Resolution

open

Fixed in Version

Status

feedback

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

pi

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

OBPS

Web browser

Google Chrome

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0046794: Support the downloads of Plain Text Reports

Description

Currently in BaseReportActionHandler class is not supported the downloads of plain text files

Steps To Reproduce

In Weldom there are reports that need to be in Plain Text but not CSV because there is not a unique separator. The fields values in the report lines are formatted/encoded with detailed lengths and indexes. So, to improve the quality of the system response to this kind of report, we need to be able to downloads plain texts as a report.

Proposed Solution

Here you can find the patch. Is just adding a condition on BaseReportActionHandler.doDownload method.

Tags

No tags attached.

SupportPlainTextReports.diff [^] (1,435 bytes) 2021-05-21 18:30 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java b/modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
index a539bb1384..4a71a695dd 100644
--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/report/BaseReportActionHandler.java
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2014-2018 Openbravo SLU 
+ * All portions are Copyright (C) 2014-2021 Openbravo SLU 
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -179,6 +179,8 @@ public class BaseReportActionHandler extends BaseProcessActionHandler {
       expType = ExportType.XLSX;
     } else if (strFileName.endsWith("." + ExportType.CSV.getExtension())) {
       expType = ExportType.CSV;
+    } else if (strFileName.endsWith("." + ExportType.TXT.getExtension())) {
+      expType = ExportType.TXT;
     } else {
       throw new IllegalArgumentException(
           "Trying to download report file with unsupported type " + strFileName);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0128644) alostale (viewer) 2021-05-26 11:06	I don't think the patch is complete. It only handles the report download, but not the definition (ie. template for plain text) nor the generation. How/when this new branch of the code gets executed?

Issue History
Date Modified	Username	Field	Change
2021-05-21 18:30	rtoledano	New Issue
2021-05-21 18:30	rtoledano	Assigned To	=> Triage Finance
2021-05-21 18:30	rtoledano	File Added: SupportPlainTextReports.diff
2021-05-21 18:30	rtoledano	OBNetwork customer	=> OBPS
2021-05-21 18:30	rtoledano	Web browser	=> Google Chrome
2021-05-21 18:30	rtoledano	Modules	=> Core
2021-05-21 18:30	rtoledano	Resolution time	=> 1622152800
2021-05-21 18:30	rtoledano	Triggers an Emergency Pack	=> No
2021-05-24 12:10	vmromanos	Web browser	Google Chrome => Google Chrome
2021-05-24 12:10	vmromanos	Assigned To	Triage Finance => platform
2021-05-24 12:10	vmromanos	Severity	critical => major
2021-05-26 11:05	alostale	Web browser	Google Chrome => Google Chrome
2021-05-26 11:05	alostale	Resolution time	1622152800 =>
2021-05-26 11:05	alostale	Type	defect => feature request
2021-05-26 11:06	alostale	Note Added: 0128644
2021-05-26 11:06	alostale	Assigned To	platform => rtoledano
2021-05-26 11:06	alostale	Status	new => feedback

Copyright © 2000 - 2009 MantisBT Group