Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046589
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorhave not tried2021-05-07 14:282021-05-23 23:10
ReporterplujanView Statuspublic 
Assigned Tohernan-dp 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046589: The Carousel pagers identifiers (data-testid) are not unique

DescriptionIn order to paginate the keymaps, the Carousel functionality introduces new components called "pagers", that are small white/grey circles at the bottom or at the right margin of the keymap.
These pagers' data-testid fields are named "-circle-0", "-circle-1" and so on. In case there are more than one pager, this means the testids are not unique.
Steps To ReproduceThe easiest way to see this is to inspect the page and seek for the "circle" text. An example screenshot is attached.
Proposed SolutionChange the name to make it unique, by adding the name of the keymap it is controlling. Also, please rename the testid from "circle" to "pager", as the shape of the component is not a good way to name it.
For example: data-testid="ProductCategory-pager-0" or "obpos2ProductCategory-pager-0"
TagsTakeaway
Attached Filespng file icon Carousel-testids.png [^] (24,297 bytes) 2021-05-07 14:28

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0046730 closedhernan-dp Carousel "arrow" keys are missing its testid 
related to defect 0046815 closedhernan-dp The Carousel vertical pagers identifiers (data-testid) for Product keymap are not properly 

-  Notes
(0127906)
hgbot (developer)
2021-05-08 00:06

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/442 [^]
(0127908)
hgbot (developer)
2021-05-08 00:08

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/494 [^]
(0128011)
hgbot (developer)
2021-05-11 21:29

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/494 [^]
(0128012)
hgbot (developer)
2021-05-11 21:29

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/442 [^]
(0128391)
plujan (viewer)
2021-05-19 10:51

 Added relationship with 0046730
(0128491)
hgbot (developer)
2021-05-21 12:49

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 788f008bbc24149c666e3460b2f57735745700a0
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-05-21T12:46:11+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/788f008bbc24149c666e3460b2f57735745700a0 [^]

fixed ISSUE-46589: Added testId threw props to pager.

---
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/BaseKeymap.jsx
M web-jspack/org.openbravo.core2/src/components/Carousel/Carousel.jsx
M web-jspack/org.openbravo.core2/src/components/Carousel/Pager/Pager.jsx
M web-jspack/org.openbravo.core2/src/components/Carousel/Pager/Pager.scss
M web-jspack/org.openbravo.core2/src/components/Carousel/Pager/__test__/Pager.test.jsx
---
(0128492)
hgbot (developer)
2021-05-21 12:49

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/494 [^]
(0128493)
hgbot (developer)
2021-05-21 12:49

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/442 [^]
(0128494)
hgbot (developer)
2021-05-21 12:49

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1fdc33f1eb12daa65988e5873a23c475db4a5a4a
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-05-21T12:46:36+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1fdc33f1eb12daa65988e5873a23c475db4a5a4a [^]

fixed ISSUE-46589: Added keymap id to test id so it isn't static.

---
M web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/ProductCategoryKeymap.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/__mock__/FullKeymapConfig.mock.json
M web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/__test__/ProductCategoryKeymap.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductKeymap/ProductKeymap.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductKeymap/__mock__/ProductKeymap.mock1.json
M web-jspack/org.openbravo.pos2/src/components/ProductKeymap/__test__/ProductKeymap.test.jsx
---
(0128499)
hgbot (developer)
2021-05-21 14:07

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 659fa8448d56c65f28ded231bd4120bf072b20a7
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-05-21T12:56:11+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/659fa8448d56c65f28ded231bd4120bf072b20a7 [^]

fixed ISSUE-46589: Added default test-id for product and product categories keymap

---
M web-jspack/org.openbravo.pos2/src/components/ProductCategoryKeymap/ProductCategoryKeymap.jsx
---
(0128521)
hgbot (developer)
2021-05-22 11:35

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/516 [^]
(0128523)
hgbot (developer)
2021-05-23 23:10

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 338a5228ba4e7c23f8f6044bded1aa8960fb117e
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-05-22T11:33:46+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/338a5228ba4e7c23f8f6044bded1aa8960fb117e [^]

Related to ISSUE-46589: fix test

---
M web-jspack/org.openbravo.core2/src/components/Carousel/CarouselButton/__test__/CarouselButton.test.jsx
---
(0128524)
hgbot (developer)
2021-05-23 23:10

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/516 [^]

- Issue History
Date Modified Username Field Change
2021-05-07 14:28 plujan New Issue
2021-05-07 14:28 plujan Assigned To => Retail
2021-05-07 14:28 plujan File Added: Carousel-testids.png
2021-05-07 14:28 plujan OBNetwork customer => Gold
2021-05-07 14:28 plujan Resolution time => 1621548000
2021-05-07 14:28 plujan Triggers an Emergency Pack => No
2021-05-07 14:42 guilleaer Tag Attached: Takeaway
2021-05-07 14:43 guilleaer Resolution time 1621548000 => 1623016800
2021-05-07 14:43 guilleaer Severity major => minor
2021-05-07 14:43 guilleaer Summary [TAP] The Carousel pagers identifiers (data-testid) are not unique => The Carousel pagers identifiers (data-testid) are not unique
2021-05-07 14:44 guilleaer Status new => acknowledged
2021-05-08 00:06 hgbot Merge Request Status => open
2021-05-08 00:06 hgbot Note Added: 0127906
2021-05-08 00:07 hgbot Note Added: 0127907
2021-05-08 00:08 hgbot Note Added: 0127908
2021-05-10 09:05 guilleaer Status acknowledged => scheduled
2021-05-10 09:05 guilleaer Assigned To Retail => hernan-dp
2021-05-10 09:08 guilleaer Note Added: 0127928
2021-05-10 09:09 guilleaer Note Deleted: 0127907
2021-05-10 09:09 guilleaer Note Deleted: 0127928
2021-05-11 21:29 hgbot Note Added: 0128011
2021-05-11 21:29 hgbot Note Added: 0128012
2021-05-19 10:50 plujan Relationship added related to 0046730
2021-05-19 10:51 plujan Note Added: 0128391
2021-05-21 12:44 hgbot Merge Request Status open => approved
2021-05-21 12:49 hgbot Resolution open => fixed
2021-05-21 12:49 hgbot Status scheduled => closed
2021-05-21 12:49 hgbot Note Added: 0128491
2021-05-21 12:49 hgbot Note Added: 0128492
2021-05-21 12:49 hgbot Note Added: 0128493
2021-05-21 12:49 hgbot Note Added: 0128494
2021-05-21 14:07 hgbot Note Added: 0128499
2021-05-22 11:35 hgbot Note Added: 0128521
2021-05-23 23:10 hgbot Note Added: 0128523
2021-05-23 23:10 hgbot Note Added: 0128524
2021-05-24 16:33 plujan Relationship added related to 0046815

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker