Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046521
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2021-05-05 16:542021-05-19 09:21
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionPR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR21Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusmerged
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046521: ant compile.test does not work incrementally because of wrong src definition

DescriptionThat ant target is used as dependency in any run of junit tests via ant.

It has a wrong src definition where the file-location in which the sources are found does not match the java-package.

That is similar to what we fixed in 20416 for the main compilation.

Effect of this bug is re-compiling 580 sources on every run of this target.
Example runtime:
- current ca. 41 seconds
- fixed: ca. 24 seconds

Apart from local waiting that is also run several times in many ci jobs:
- At least twice for stand-alone + webservice tests
- in jobs with custom junit tests even more times (+1 per each module)
  i.e. mod-platform runs that compile step 6 times and other mod-* jobs even more times

Steps To Reproducerun ant compile.test
run ant compile.test a second time

Notice that the 2nd compilation does compile many sources files when it should compile 0 (as there are no source changes).
TagsNo tags attached.
Attached Filesdiff file icon 46521.diff [^] (560 bytes) 2021-05-05 16:56 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0020416 closedmarvintm Improve compilation task so that it doesn't always compile java files inside the modules folder 
depends on backport 0046549PR21Q2 closedshuehner ant compile.test does not work incrementally because of wrong src definition 
depends on backport 0046550PR21Q1.3 closedshuehner ant compile.test does not work incrementally because of wrong src definition 
depends on backport 0046551PR20Q4.5 closedshuehner ant compile.test does not work incrementally because of wrong src definition 

-  Notes
(0127837)
shuehner (administrator)
2021-05-05 16:57

 Candidate for back-patching to all versions we cover in CI (including customer jobs) to get the speed benefit.
(0128370)
hgbot (developer)
2021-05-19 09:14

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/372 [^]
(0128378)
hgbot (developer)
2021-05-19 09:21

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/372 [^]
(0128379)
hgbot (developer)
2021-05-19 09:21

 Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: fbdc484fc99309f1b21ecc6cdf436b182bfe2257
Author: Stefan Hühner <stefan.huehner@openbravo.com>
Date: 2021-05-19T09:13:11+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/fbdc484fc99309f1b21ecc6cdf436b182bfe2257 [^]

fixed BUG-46521: ant compile.test does not work incrementally

Whenever compile.test task was executed all test classes were compiled
instead of doing an incremental compilation of the only the ones whose
source files changed since last compilation.

This was caused by an incorrect path definition of tests in core module,
sources are within src-test/src directory but pathelement was declared
as src-test only, this makes ant not to be able to detect changes and to
always compile all the files. See [1].

[1] https://ant.apache.org/faq.html#always-recompiles [^]

---
M src-test/build.xml
---

- Issue History
Date Modified Username Field Change
2021-05-05 16:54 shuehner New Issue
2021-05-05 16:54 shuehner Assigned To => platform
2021-05-05 16:54 shuehner OBNetwork customer => No
2021-05-05 16:54 shuehner Modules => Core
2021-05-05 16:54 shuehner Triggers an Emergency Pack => No
2021-05-05 16:54 shuehner Relationship added related to 0020416
2021-05-05 16:56 shuehner File Added: 46521.diff
2021-05-05 16:57 shuehner Note Added: 0127837
2021-05-05 16:57 shuehner Target Version => PR21Q3
2021-05-06 14:39 shuehner Status new => scheduled
2021-05-19 07:47 alostale Assigned To platform => shuehner
2021-05-19 09:14 hgbot Merge Request Status => open
2021-05-19 09:14 hgbot Note Added: 0128370
2021-05-19 09:21 hgbot Resolution open => fixed
2021-05-19 09:21 hgbot Status scheduled => resolved
2021-05-19 09:21 hgbot Merge Request Status open => merged
2021-05-19 09:21 hgbot Note Added: 0128378
2021-05-19 09:21 hgbot Fixed in Version => PR21Q3
2021-05-19 09:21 hgbot Note Added: 0128379
2021-05-19 09:21 alostale Review Assigned To => alostale
2021-05-19 09:21 alostale Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker