Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0046501 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] 03. Procurement management | major | always | 2021-05-05 06:56 | 2021-05-17 16:20 | |||
Reporter | lbressan | View Status | public | |||||
Assigned To | vmromanos | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | PR21Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | dmiguelez | |||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | 23685 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0046501: The lines of requisition do not allow to put quantity less than 1. | |||||||
Description | The lines of requisition do not allow to put quantity less than 1. | |||||||
Steps To Reproduce | Create requisition. Create requisition line. Put quantity less than 1. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0127819) dmiguelez (viewer) 2021-05-05 11:22 |
This is not an issue, it is the expected behavior. From a functional point of view, within the Openbravo context, it does not make sense to create negative lines within a Requisition. However, if the client is working with a different scenario, this can be easily customized through Application Dictionary. It is possible to change the Min. Value of the Quantity column of the ProcurementRequisitionLine Table through a custom template |
(0127831) Practics (viewer) 2021-05-05 14:43 |
David, no es poder meter líneas negativas. Sino que no permite poner 0,5 y esto debe ser posible. |
(0127833) dmiguelez (viewer) 2021-05-05 15:44 |
Thanks to the updated explanation of this issue we can consider this problem something to be fixed. The solution should have 2 steps: 1. Update the definition of the Min. Value in Application Dictionary to 0 2. Ensure that only values greater than 0 are introduced by (0 should not be allowed): - Option 1: Create a constraint in the DB (this implies to create a functional API change as the DB will be more restricted than before) - Option 2: Create an Event Observer to implement this restriction |
(0128007) vmromanos (viewer) 2021-05-11 17:51 |
Test plan: Login as Openbravo admin Go to Requisition window Enter a new header and save it. Create a new line. Fill the mandatory fields. In quantity field enter 0 and save the record. Verify an error is raised. In quantity field enter -1 and save the record. Verify an error is raised. In quantity field enter -0.1 and save the record. Verify an error is raised In quantity field enter 1 and save the record. Verify it's successfully saved. In quantity field enter 0.01 and save the record. Verify it's successfully saved. |
(0128033) hgbot (developer) 2021-05-12 11:16 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/360 [^] |
(0128261) hgbot (developer) 2021-05-17 16:20 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 47d18499ac317c49f8608ee0a77e87d7cdedcb1e Author: Víctor Martínez Romanos <victor.martinez@openbravo.com> Date: 2021-05-17T14:19:32+00:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/47d18499ac317c49f8608ee0a77e87d7cdedcb1e [^] Fixed ISSUE-46501: Requisition line qty min value allows > 0 The min value of any quantity column has been changed from 1 to 1E-20, which easily allows to save a value greater than 0 with enough precission. Note that the NumericPropertyValidator.validate() is in charge of validating the number. It uses the BigDecimal(String) constructor, where the param is "1E-20", which is a valid string for this constructor. --- M src-db/database/sourcedata/AD_COLUMN.xml --- |
(0128262) hgbot (developer) 2021-05-17 16:20 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/360 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2021-05-05 06:56 | lbressan | New Issue | |
2021-05-05 06:56 | lbressan | Assigned To | => Triage Finance |
2021-05-05 06:56 | lbressan | OBNetwork customer | => OBPS |
2021-05-05 06:56 | lbressan | Modules | => Core |
2021-05-05 06:56 | lbressan | Resolution time | => 1621893600 |
2021-05-05 06:56 | lbressan | Triggers an Emergency Pack | => No |
2021-05-05 08:34 | Practics | Issue Monitored: Practics | |
2021-05-05 11:22 | dmiguelez | Review Assigned To | => dmiguelez |
2021-05-05 11:22 | dmiguelez | Note Added: 0127819 | |
2021-05-05 11:22 | dmiguelez | Status | new => closed |
2021-05-05 11:22 | dmiguelez | Resolution | open => invalid |
2021-05-05 14:43 | Practics | Note Added: 0127831 | |
2021-05-05 15:44 | dmiguelez | Note Added: 0127833 | |
2021-05-05 15:44 | dmiguelez | Status | closed => new |
2021-05-05 15:44 | dmiguelez | Resolution | invalid => open |
2021-05-05 15:53 | dmiguelez | Support ticket | => 23685 |
2021-05-11 14:15 | vmromanos | Status | new => scheduled |
2021-05-11 14:15 | vmromanos | Assigned To | Triage Finance => vmromanos |
2021-05-11 17:51 | vmromanos | Note Added: 0128007 | |
2021-05-12 11:16 | hgbot | Merge Request Status | => open |
2021-05-12 11:16 | hgbot | Note Added: 0128033 | |
2021-05-17 16:19 | hgbot | Merge Request Status | open => approved |
2021-05-17 16:20 | hgbot | Resolution | open => fixed |
2021-05-17 16:20 | hgbot | Status | scheduled => closed |
2021-05-17 16:20 | hgbot | Fixed in Version | => PR21Q3 |
2021-05-17 16:20 | hgbot | Note Added: 0128261 | |
2021-05-17 16:20 | hgbot | Note Added: 0128262 |
Copyright © 2000 - 2009 MantisBT Group |