Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045803 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2021-01-28 17:54 | 2021-01-29 10:08 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR21Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | Gold | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045803: MessageBar shows on top of all windows when tab is closed and some ActionHandler callback is still pending | |||||||
| Description | A red/green message bar is shown on the top of the ERP(see attached screenshot) when some handler, for example (GetTabMessageActionHandler) finishes after the current tab(that executed that ActionHandler) has been closed. | |||||||
| Steps To Reproduce | 1. Open ERP and login 2. Add a breakpoint at the start of GetTabMessageActionHandler.execute method 3. Open in ERP, Sales Order window 4. Create a new Order, and don't add any product lines. 5. Press "Book" and "OK" on the popup. 6. Check that the tomcat instance has stopped on the breakpoint placed earlier 7. Close the Sales Order tab in ERP 8. Resume execution in the tomcat instance A red message bar will appear on top. Check screenshot attached. | |||||||
| Proposed Solution | Check in ob-standard-view.js in getTabMessage callback if the clientContext.messageBar/window is actually valid and not null. Only setMessage when it is valid. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  redbarWindow.png [^] (269,408 bytes) 2021-01-28 17:55 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0125839) hgbot (developer) 2021-01-28 18:02 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/292 [^] |
|
(0125850) hgbot (developer) 2021-01-29 10:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 831e0eff80ddf49b9a1d5f85bc013e57116eaf6a Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2021-01-29T10:02:49+01:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/831e0eff80ddf49b9a1d5f85bc013e57116eaf6a [^] Fixes ISSUE-45803: MessageBar shows on top of all windows when tab is closed before ActionHandler A red/green message bar appears on top if a tab is closed before a process ActionHandler had time to return the results. This was due to how the context is being checked in getTabMessage method, an wrong clientContext.messageBar was being used without checking if it still exists in the current window. This fixes it by checking if the window contains the saved clientContext element and it's the same as the one who called the handler. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0125851) hgbot (developer) 2021-01-29 10:08 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/292 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-01-28 17:54 | cberner | New Issue | |
| 2021-01-28 17:54 | cberner | Assigned To | => cberner |
| 2021-01-28 17:54 | cberner | OBNetwork customer | => No |
| 2021-01-28 17:54 | cberner | Modules | => Core |
| 2021-01-28 17:54 | cberner | Triggers an Emergency Pack | => No |
| 2021-01-28 17:55 | cberner | File Added: redbarWindow.png | |
| 2021-01-28 18:02 | hgbot | Merge Request Status | => open |
| 2021-01-28 18:02 | hgbot | Note Added: 0125839 | |
| 2021-01-28 18:13 | egoitz | OBNetwork customer | No => Gold |
| 2021-01-29 10:07 | hgbot | Merge Request Status | open => approved |
| 2021-01-29 10:08 | hgbot | Resolution | open => fixed |
| 2021-01-29 10:08 | hgbot | Status | new => closed |
| 2021-01-29 10:08 | hgbot | Fixed in Version | => PR21Q2 |
| 2021-01-29 10:08 | hgbot | Note Added: 0125850 | |
| 2021-01-29 10:08 | hgbot | Note Added: 0125851 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |