Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045282 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] IDL For Variants | minor | have not tried | 2020-10-22 14:20 | 2020-10-23 07:00 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0045282: idl.variants ImportProduct makes use of deprecated Brand entity | |||||||
| Description | ImportProduct class makes use of deprecated Brand entity and a java compiler warning is thrown because of this. Although ImportProduct has a @SuppressWarnings("deprecation") annotation at the level class, it is not enough because Brand class is imported directly. (Note, this only fails in Java 8, because Java9 fixes this import deprecated detection) | |||||||
| Steps To Reproduce | In description. | |||||||
| Proposed Solution | Use Brand class explicitly, without importing it at the top level of the class. In the future, remove usage of deprecated Brand class. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0123873) hgbot (developer) 2020-10-22 14:30 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants/-/merge_requests/2 [^] |
|
(0123894) hgbot (developer) 2020-10-23 07:00 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants [^] Changeset: a059c3c058b004df867a25a6ffdf23ccce959adb Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2020-10-22T14:29:36+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants/-/commit/a059c3c058b004df867a25a6ffdf23ccce959adb [^] Fixes ISSUE-45282: ImportProduct makes use of deprecated Brand entity @SuppressWarnings("deprecation") annotation being used at class level in ImportProduct is not enough to suppress the warnings of Brand entity usage, because Java 8 compiler fails if it is imported explicitly. To fix this, the supress warnings annotation has been moved to the method that makes use of the deprecated entity, and all usages of Brand now explicitly use the class+package without importing it at the top of ImportProduct class. --- M src/org/openbravo/idl/variants/ImportProduct.java --- |
|
(0123895) hgbot (developer) 2020-10-23 07:00 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants/-/merge_requests/2 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-10-22 14:20 | cberner | New Issue | |
| 2020-10-22 14:20 | cberner | Assigned To | => cberner |
| 2020-10-22 14:24 | cberner | Relationship added | caused by 0045029 |
| 2020-10-22 14:30 | hgbot | Note Added: 0123873 | |
| 2020-10-23 07:00 | hgbot | Resolution | open => fixed |
| 2020-10-23 07:00 | hgbot | Status | new => closed |
| 2020-10-23 07:00 | hgbot | Note Added: 0123894 | |
| 2020-10-23 07:00 | hgbot | Note Added: 0123895 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |