Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044050
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-13 11:332020-05-20 12:28
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4484dda1b5bf
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044050: Apply new HQL Style in AvailableLocatorsUtils.java

DescriptionAvailableLocatorsUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119836)
inigo_lerga (reporter)
2020-05-13 13:50
edited on: 2020-05-15 11:58

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120093)
hgbot (developer)
2020-05-20 12:25

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 85983242ca5e71e7a1c0b66fe0465f884e843778
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 13 13:58:34 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/85983242ca5e71e7a1c0b66fe0465f884e843778 [^]

related to ISSUE-44050:SimpleQueryBuilder uses now String

Instead of StringBuilder, now String is used to save
the hql query. This change is made to follow new
hql queries format.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/SimpleQueryBuilder.java
---
(0120094)
hgbot (developer)
2020-05-20 12:25

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 4484dda1b5bf0f65d550b11414b913fe61ad1cba
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 13 14:09:30 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4484dda1b5bf0f65d550b11414b913fe61ad1cba [^]

fixes BUG-44050:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/AvailableLocatorsUtils.java
---
(0120095)
hgbot (developer)
2020-05-20 12:25

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: a31230a4bca3aa7aaf91647817bee7b4de2436d6
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 13 15:16:19 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a31230a4bca3aa7aaf91647817bee7b4de2436d6 [^]

related to ISSUE-44050:PA_QueryBuilder SimpleQueryBuilder update

Due to the modification of SimpleQueryBuilder to use String
insted of SimpleBuilder to save the hql query, the hql in
PA_QueryBuilder now can be made also with String.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/PA_QueryBuilder.java
---
(0120096)
hgbot (developer)
2020-05-20 12:25

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5f7e381f991dc8a2f489df25946340b6f85012ec
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 13 15:41:58 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5f7e381f991dc8a2f489df25946340b6f85012ec [^]

related to ISSUE-44050:GroupOfTasksConfirmator SimpleQueryBuilder update

Due to the modification of SimpleQueryBuilder to use String
insted of SimpleBuilder to save the hql query, the hql in
GroupOfTasksConfirmator now can be made also with String.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/GroupOfTasksConfirmator.java
---
(0120097)
hgbot (developer)
2020-05-20 12:25

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 49decd0c175f1c66d33d724ad973c7dfc19571e9
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed May 20 10:23:14 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/49decd0c175f1c66d33d724ad973c7dfc19571e9 [^]

Related to ISSUE-44050. Improve redability
  * Collapse senteces to make them easier to read
  * remove some consecutive formatters on/off to make the code easier to read

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/GroupOfTasksConfirmator.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/AvailableLocatorsUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/PA_QueryBuilder.java
---
(0120098)
hgbot (developer)
2020-05-20 12:25

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 194dc64b9273a949a4b6a277348b6c14bff8d76e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed May 20 12:25:31 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/194dc64b9273a949a4b6a277348b6c14bff8d76e [^]

Related to ISSUE-44050. Added back alias for tables using a class constant.

Since this classes are meant to be extended to modify the query, some
class constants have been defined to use as table aliases.
By doing so, it avoid possible problems when extending the query.
This constants are now used as the table alias in the hql query.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/AvailableLocatorsUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/PA_QueryBuilder.java
---
(0120099)
dmiguelez (developer)
2020-05-20 12:28

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-13 11:33 inigo_lerga New Issue
2020-05-13 11:33 inigo_lerga Assigned To => inigo_lerga
2020-05-13 11:33 inigo_lerga Relationship added related to 0041287
2020-05-13 11:33 inigo_lerga Status new => scheduled
2020-05-13 13:50 inigo_lerga Note Added: 0119836
2020-05-15 11:56 inigo_lerga Note Edited: 0119836 View Revisions
2020-05-15 11:58 inigo_lerga Note Edited: 0119836 View Revisions
2020-05-20 12:25 hgbot Checkin
2020-05-20 12:25 hgbot Note Added: 0120093
2020-05-20 12:25 hgbot Checkin
2020-05-20 12:25 hgbot Note Added: 0120094
2020-05-20 12:25 hgbot Status scheduled => resolved
2020-05-20 12:25 hgbot Resolution open => fixed
2020-05-20 12:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/4484dda1b5bf0f65d550b11414b913fe61ad1cba [^]
2020-05-20 12:25 hgbot Checkin
2020-05-20 12:25 hgbot Note Added: 0120095
2020-05-20 12:25 hgbot Checkin
2020-05-20 12:25 hgbot Note Added: 0120096
2020-05-20 12:25 hgbot Checkin
2020-05-20 12:25 hgbot Note Added: 0120097
2020-05-20 12:25 hgbot Checkin
2020-05-20 12:25 hgbot Note Added: 0120098
2020-05-20 12:28 dmiguelez Review Assigned To => dmiguelez
2020-05-20 12:28 dmiguelez Note Added: 0120099
2020-05-20 12:28 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker