Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043903
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformminorhave not tried2020-04-29 16:412020-11-06 08:44
ReportershuehnerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043903: Openbravo fails to compile with JDK15 because of removal of Nashorn JS engine

DescriptionProject: http://wiki.openbravo.com/wiki/Projects:Add_JavaScript_Engine [^]

The Nashorn JS engine shipped with OpenJDK was marked as deprecated since JDK11 and has been removed for JDK15 (since build ea20)

pi fails to compile since then as it still references this engine in some places.

    [javac] src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java:37: error: package jdk.nashorn.api.scripting does not exist
    [javac] import jdk.nashorn.api.scripting.JSObject;
    [javac] ^
    [javac] src/org/openbravo/erpCommon/ad_callouts/HttpServletCalloutInformationProvider.java:58: error: cannot find symbol
    [javac] private List<JSObject> responseElements;
    [javac] ^
    [javac] symbol: class JSObject
    [javac] location: class HttpServletCalloutInformationProvider

https://openjdk.java.net/jeps/372 [^]
https://openjdk.java.net/projects/jdk/15/ [^]
Steps To ReproduceDownload Openjdk15 (at least Build20 or higher) from:
https://jdk.java.net/15/ [^]

Set JAVA_HOME to using it.
run install.source
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0044803 closedplatform Support for old-style callout (HttpServletBased and not SimpleCallout) should be removed (for generated-Windows, ad_callout) 
has duplicate design defect 0040533 closedplatform remove rhino copies in lib/build 
related to defect 0045364 closedcberner Remove org.openbravo.javascript from filter list in backoffice-api 
blocks feature request 0043901 closedplatform Support JDK15 
causes defect 0045375 closedcberner API Change: Remove org.openbravo.classfile package, part of removed ob-rhino library 
causes defect 0045400 closedcberner Eclipse OpenbravoTest project fails to compile, missing src folder in .project config 

-  Notes
(0119497)
shuehner (administrator)
2020-04-29 16:48

 Apart of that compilation error the following code likely also requires adjustment/testing:

https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java#l192 [^]
(0123577)
hgbot (developer)
2020-10-06 16:56

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/193 [^]
(0124165)
hgbot (developer)
2020-11-04 13:34

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/193 [^]
(0124166)
hgbot (developer)
2020-11-04 13:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 10ed85e9856caae58a7281f28a3446a036da0a26
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-11-04T13:31:34+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/10ed85e9856caae58a7281f28a3446a036da0a26 [^]

Fixes ISSUE-43903: Fix JDK15 compilation after removal of NashornJS

JDK15 removes Nashorn JavaScript engine. A new engine is added with this
project, Rhino.

This project also removes yuicompressor and substitutes it with an Ant
task using JSMin and removes older repackaged versions of rhino.

MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/193 [^]

---
A lib/runtime/rhino-1.7.13.jar
A lib/runtime/rhino-engine-1.7.13.jar
A src/org/openbravo/erpCommon/utility/JSMinifyTask.java
M build.xml
M legal/Licensing.txt
M modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
M modules/org.openbravo.userinterface.selector/src-test/org/openbravo/userinterface/selectors/test/ExpressionsTest.java
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src-test/src/org/openbravo/test/expression/OBBindingsTest.java
M src/build.xml
M src/org/openbravo/base/expression/OBScriptEngine.java
R lib/build/YUIAnt.jar
R lib/build/js.jar
R lib/build/ob-rhino-1.6R7.jar
R lib/build/yuicompressor-2.4.2.jar
---
(0124174)
hgbot (developer)
2020-11-04 14:04

 Repository: https://gitlab.com/openbravo/tools/platform/dependencies [^]
Changeset: 9011007ff63e48e5b8ee9064122c5060df3d7201
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-11-04T14:04:02+01:00
URL: https://gitlab.com/openbravo/tools/platform/dependencies/-/commit/9011007ff63e48e5b8ee9064122c5060df3d7201 [^]

Related to ISSUE-43903: Add rhino and rhino-engine dependencies

---
M build.gradle
---

- Issue History
Date Modified Username Field Change
2020-04-29 16:41 shuehner New Issue
2020-04-29 16:41 shuehner Assigned To => platform
2020-04-29 16:41 shuehner Modules => Core
2020-04-29 16:41 shuehner Triggers an Emergency Pack => No
2020-04-29 16:41 shuehner Relationship added blocks 0043901
2020-04-29 16:48 shuehner Note Added: 0119497
2020-08-12 16:59 shuehner Relationship added related to 0044803
2020-10-06 16:56 hgbot Note Added: 0123577
2020-10-27 09:47 cberner Assigned To platform => cberner
2020-10-27 09:48 cberner Status new => scheduled
2020-11-03 09:57 cberner Relationship added causes 0045364
2020-11-03 09:57 cberner Relationship deleted causes 0045364
2020-11-03 09:57 cberner Relationship added related to 0045364
2020-11-04 13:19 cberner Relationship added causes 0045375
2020-11-04 13:34 hgbot Resolution open => fixed
2020-11-04 13:34 hgbot Status scheduled => closed
2020-11-04 13:34 hgbot Note Added: 0124165
2020-11-04 13:34 hgbot Fixed in Version => PR21Q1
2020-11-04 13:34 hgbot Note Added: 0124166
2020-11-04 14:04 hgbot Note Added: 0124174
2020-11-06 08:43 alostale Description Updated View Revisions
2020-11-06 08:44 alostale Description Updated View Revisions
2020-11-09 14:20 cberner Relationship added causes 0045400
2021-06-11 14:02 shuehner Relationship added has duplicate 0040533

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker