0043406: SCO - Max/min payment amounts not taken into account

Description

Using SCO, the maximum and minimum amounts set in backend (Touchpoint > Payment method) are not taken into account when paying a ticket.

Steps To Reproduce

-Login the backend and open the 'Touchpoint window
-Select your SCO terminal
-In payment method window, select 'gift card' (carte cadeau) payment method, for example
-Set the minimum amount to 0.9€ and the maximum to 1.5€
-Save the record

For the minimum:
-Login your SCO terminal (press F5 if needed)
-Add the 2000767 item to the ticket (0.01€)
-Finish and pay
-Loyalty prop > No
-Select gift card payment
-Scan your giftcard 777701754065057411118000000009780186601
-Check that the min amount set is not taken into account

For the maximum:
-Login your SCO terminal (press F5 if needed)
-Add the 75284 item to the ticket (1€)
-Add the 75284 item to the ticket (1€)
-Finish and pay
-Loyalty prop > No
-Select gift card payment
-Scan your giftcard 777701754065057411118000000009780186601
-Check that the max amount set is not taken into account

PLEASE DO THE SAME CHECK FOR ILICADO PAYMENT METHOD USING 9250004105000379896D20081011065717129 CARD NUMBER

Tags

No tags attached.

Attached Files

Issue_0043210_SCO_Max_min_payment_amounts_not_taken_into_account.patch [^] (2,563 bytes) 2020-03-03 15:14 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.selfcheckout/source/panels/selectPaymentPanel.js b/web/org.openbravo.retail.selfcheckout/source/panels/selectPaymentPanel.js
index 42824d8..f04f165 100644
--- a/web/org.openbravo.retail.selfcheckout/source/panels/selectPaymentPanel.js
+++ b/web/org.openbravo.retail.selfcheckout/source/panels/selectPaymentPanel.js
@@ -71,13 +71,70 @@ enyo.kind({
   },
   show: function() {
     this.inherited(arguments);
-
+    //Show only payment methods available for SCO.
+    this.getComponents()
+      .filter(e => e.kind === 'OB.SCO.ButtonPayment')
+      .forEach(function(button, index) {
+        if (
+          (OB.SCO.Utils.isSCOReturn() &&
+            button.payment.paymentMethod.obscoEnableForSCOReturn) ||
+          (!OB.SCO.Utils.isSCOReturn() &&
+            button.payment.paymentMethod.obscoEnableForSCOPayment)
+        ) {
+          button.show();
+        } else {
+          button.hide();
+        }
+      });
     // Show or hide button to add more products depending on the receipt payment value
     this.$.buttonSelectPaymentBack.setShowing(
       this.receipt.get('payment') === 0
     );
   },
   selectPayment: function(inSender, inEvent) {
+    if (
+      inSender.payment.paymentMethod.mINLimitAmount &&
+      inSender.payment.paymentMethod.maxLimitAmount
+    ) {
+      if (
+        inSender.payment.paymentMethod.mINLimitAmount >
+        inSender.container.owner.receipt.getNet()
+      ) {
+        OB.SCO.Utils.hideLoading();
+
+        OB.SCO.Utils.showPaymentError({
+          i18nParameters: [
+            OB.I18N.getLabel('OBPOS_PaymentMinLimitAmount', [
+              OB.I18N.formatCurrencyWithSymbol(
+                inSender.payment.paymentMethod.mINLimitAmount,
+                inSender.payment.symbol,
+                inSender.payment.symbol
+              )
+            ])
+          ]
+        });
+
+        return;
+      }
+
+      if (
+        inSender.payment.paymentMethod.maxLimitAmount <
+        inSender.container.owner.receipt.getNet()
+      ) {
+        OB.SCO.Utils.showPaymentError({
+          i18nParameters: [
+            OB.I18N.getLabel('OBPOS_PaymentMaxLimitAmount', [
+              OB.I18N.formatCurrencyWithSymbol(
+                inSender.payment.paymentMethod.maxLimitAmount,
+                inSender.payment.symbol,
+                inSender.payment.symbol
+              )
+            ])
+          ]
+        });
+        return;
+      }
+    }
     this.executeEvent({
       name: 'GoPaymentProvider',
       payment: inSender.payment

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2020-03-03 15:14	eugeniadiaz	New Issue
2020-03-03 15:14	eugeniadiaz	Assigned To	=> Retail
2020-03-03 15:14	eugeniadiaz	File Added: Issue_0043210_SCO_Max_min_payment_amounts_not_taken_into_account.patch
2020-03-03 15:14	eugeniadiaz	Triggers an Emergency Pack	=> No