Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0042404

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2019-11-26 16:06

2019-12-09 13:44

Reporter

samuel_nicuesa

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR20Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

13112

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0042404: Approvals for return should take into account the gross amount instead of the negative lines

Description

Approvals for return should take into account the gross amount instead of the negative lines

Steps To Reproduce

Enable Web POS Returns Approval preference
Do verified return
Add some lines until having the Gross Amount > 0
The approval is shown if the total amount is > 0

Request to change it and display the approval only if the gross amount is < 0

Tags

No tags attached.

issue42404.diff [^] (839 bytes) 2019-11-26 16:08 [Show Content] [Hide Content]

diff -r bc3da37da488 web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js	Mon Oct 21 13:05:21 2019 +0200
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js	Tue Nov 26 16:01:17 2019 +0100
@@ -1974,14 +1974,8 @@
         caller: caller
       },
       function(args) {
-        var negativeLines = _.filter(
-          me.get('order').get('lines').models,
-          function(line) {
-            return line.get('qty') < 0;
-          }
-        ).length;
         if (
-          negativeLines > 0 &&
+          me.get('order').getGross() < 0 &&
           !OB.MobileApp.model.get('permissions')['OBPOS_approval.returns']
         ) {
           args.approvals.push('OBPOS_approval.returns');

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0116136) hgbot (developer) 2019-12-08 04:24	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a4ef7f8186035a1b17022b1c4623cf0a33a44d79 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Fri Dec 06 16:38:50 2019 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4ef7f8186035a1b17022b1c4623cf0a33a44d79 [^] Fixed issue 42404: Approvals for return should take into account the gross amount instead of the negative lines - The approval popup only is shown if the gross amount is < 0 --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js ---

Issue History
Date Modified	Username	Field	Change
2019-11-26 16:06	samuel_nicuesa	New Issue
2019-11-26 16:06	samuel_nicuesa	Assigned To	=> Retail
2019-11-26 16:06	samuel_nicuesa	OBNetwork customer	=> Gold
2019-11-26 16:06	samuel_nicuesa	Support ticket	=> 13112
2019-11-26 16:06	samuel_nicuesa	Resolution time	=> 1576537200
2019-11-26 16:06	samuel_nicuesa	Triggers an Emergency Pack	=> No
2019-11-26 16:08	samuel_nicuesa	File Added: issue42404.diff
2019-12-05 17:10	rqueralta	Assigned To	Retail => rqueralta
2019-12-05 17:10	rqueralta	Status	new => scheduled
2019-12-08 04:24	hgbot	Checkin
2019-12-08 04:24	hgbot	Note Added: 0116136
2019-12-08 04:24	hgbot	Status	scheduled => resolved
2019-12-08 04:24	hgbot	Resolution	open => fixed
2019-12-08 04:24	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4ef7f8186035a1b17022b1c4623cf0a33a44d79 [^]
2019-12-09 13:44	marvintm	Review Assigned To	=> marvintm
2019-12-09 13:44	marvintm	Status	resolved => closed
2019-12-09 13:44	marvintm	Fixed in Version	=> RR20Q1

Copyright © 2000 - 2009 MantisBT Group