0041715: Error applying manual discount in WebPOS

Description

When applying a manual discount / promotion, the "rule" property of the "promotion" parameter in the addManual method of the promotion is recursively saved, as can be seen in the video.

https://drive.google.com/file/d/1pnDYU3iXPoB39n78k_fM8LZ2WR9Rx_yx/view [^]

Steps To Reproduce

When a manual discount is applied, the promotion that is saved on the order line is saved incorrectly, since the <rule> property of the <promotions> object is assigned with the <promo> object instead of <promo.rule> , as you can see in the attached screenshot. Something similar happens in the addManualPromotionSplit method of the kind OB.UI.ModalSplitLine and in the preAction and postAction method of the DiscountsExecutor model.

Tags

No tags attached.

Attached Files

bug-ob-2019-08-28.png2019-08-28.png [^] (18,107 bytes) 2019-08-28 20:51

rule_recursion_patch.diff [^] (1,567 bytes) 2019-08-28 20:54 [Show Content] [Hide Content]

diff -r de2e6635735d -r 44e862a6e18a web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js
--- a/web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js	Tue May 07 12:00:03 2019 +0000
+++ b/web/org.openbravo.retail.posterminal/js/components/modalsplitlines.js	Wed Aug 28 12:21:06 2019 -0300
@@ -375,7 +375,7 @@
     var adjustedPromotion = this.getAdjustedPromotion(promo, line.get('qty'));
     OB.Model.Discounts.addManualPromotion(this.receipt, [line], {
       definition: adjustedPromotion,
-      rule: new Backbone.Model(adjustedPromotion)
+      rule: new Backbone.Model(adjustedPromotion.rule)
     });
   },
 
diff -r de2e6635735d -r 44e862a6e18a web/org.openbravo.retail.posterminal/js/model/executor.js
--- a/web/org.openbravo.retail.posterminal/js/model/executor.js	Tue May 07 12:00:03 2019 +0000
+++ b/web/org.openbravo.retail.posterminal/js/model/executor.js	Wed Aug 28 12:21:06 2019 -0300
@@ -366,7 +366,7 @@
     _.forEach(beforeManualPromo, function (promo) {
       promo.qtyOffer = undefined;
       var promotion = {
-        rule: new Backbone.Model(promo),
+        rule: new Backbone.Model(promo.rule),
 
         definition: {
           userAmt: promo.userAmt,
@@ -397,7 +397,7 @@
         _.forEach(afterManualPromo, function (promo) {
           promo.qtyOffer = undefined;
           var promotion = {
-            rule: new Backbone.Model(promo),
+            rule: new Backbone.Model(promo.rule),
             definition: {
               userAmt: promo.userAmt,
               applyNext: promo.applyNext,

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2019-08-28 20:51	lbressan	New Issue
2019-08-28 20:51	lbressan	Assigned To	=> Retail
2019-08-28 20:51	lbressan	File Added: bug-ob-2019-08-28.png2019-08-28.png
2019-08-28 20:51	lbressan	OBNetwork customer	=> No
2019-08-28 20:51	lbressan	Triggers an Emergency Pack	=> No
2019-08-28 20:54	lbressan	File Added: rule_recursion_patch.diff
2019-08-29 04:30	matias-bernal	Support ticket	=> 11527
2019-08-29 08:33	javietxe	Issue Monitored: javietxe
2019-08-29 12:04	martinsdan	Issue Monitored: martinsdan
2024-11-14 17:28	javietxe	Issue End Monitor: javietxe
2025-01-23 11:56	guillermogil	Review Assigned To	=> guillermogil
2025-01-23 11:56	guillermogil	Status	new => closed
2025-01-23 11:56	guillermogil	Resolution	open => out of date