0041260: PaymentReportDao is not using bind-param

Description

Several cases in that file are not using bind-param both for simple values i.e. here:
          hsqlScript.append(" and fpsd.");
          hsqlScript.append(FIN_PaymentScheduleDetail.PROPERTY_ORGANIZATION);
          hsqlScript.append(".id = '");
          hsqlScript.append(strOrg);
          hsqlScript.append("'");

as well as for list of values in in-clauses:
          hsqlScript.append(".id in ('");
          Set<String> orgChildTree = OBContext.getOBContext()
              .getOrganizationStructureProvider()
              .getChildTree(strOrg, true);
          Iterator<String> orgChildTreeIter = orgChildTree.iterator();
          while (orgChildTreeIter.hasNext()) {
            hsqlScript.append(orgChildTreeIter.next());
            orgChildTreeIter.remove();
            hsqlScript.append("'");
            if (orgChildTreeIter.hasNext()) {
              hsqlScript.append(", '");
            }
          }
          hsqlScript.append(")");
        }

Note: that setParameterList can be easily use to pass value lists directly see issue 40580 for an example

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0041199

3.0PR19Q4

closed

collazoandy4

PaymentReportDao is not using bind-param

Notes
(0113433) hgbot (developer) 2019-07-16 16:41	Repository: erp/backports/3.0PR19Q1.3 Changeset: 90515e679dece1db9046baaaa06ddcbe142b1bf8 Author: Armaignac <collazoandy4 <at> gmail.com> Date: Tue Jul 16 12:09:54 2019 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/90515e679dece1db9046baaaa06ddcbe142b1bf8 [^] Fixes issue 41260: PaymentReportDao is not using bind-param Applied bind-params in getPaymentReport method --- M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java ---

(0113436) dmiguelez (developer) 2019-07-16 16:42	Code Review + Testing Ok

Issue History
Date Modified	Username	Field	Change
2019-07-03 17:00	shuehner	Type	defect => backport
2019-07-03 17:00	shuehner	Target Version	=> 3.0PR19Q1.2
2019-07-09 18:19	shuehner	Target Version	3.0PR19Q1.2 => 3.0PR19Q1.3
2019-07-16 16:41	hgbot	Checkin
2019-07-16 16:41	hgbot	Note Added: 0113433
2019-07-16 16:41	hgbot	Status	scheduled => resolved
2019-07-16 16:41	hgbot	Resolution	open => fixed
2019-07-16 16:41	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/90515e679dece1db9046baaaa06ddcbe142b1bf8 [^]
2019-07-16 16:42	dmiguelez	Review Assigned To	=> dmiguelez
2019-07-16 16:42	dmiguelez	Note Added: 0113436
2019-07-16 16:42	dmiguelez	Status	resolved => closed
2019-07-16 16:42	dmiguelez	Fixed in Version	=> 3.0PR19Q1.3