Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041034 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | major | have not tried | 2019-06-05 16:43 | 2019-06-07 08:01 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR19Q2.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 36c7590bae0a | ||||
| Projection | none | ETA | none | Target Version | 3.0PR19Q2.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2019-01-08 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/90c48060859cc70935add00e77e8065dedb197cc [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0041034: ImportEntryPreProcessors with qualifiers are not executed | |||||||
| Description | ImportEntryPreProcessors with qualifiers are not executed | |||||||
| Steps To Reproduce | 1) Apply the attached patch, it contains a test case that assumes thatImportEntryPreProcessors are executed 2) Run the test. It fails. Note that the TestImportEntryPreProcessor is not executed. 3) Remove the Qualifier annotation from the TestImportEntryPreProcessor class and rerun the test. Note that now it works. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0112461) hgbot (developer) 2019-06-06 11:09 |
Repository: erp/backports/3.0PR19Q2.1 Changeset: 36c7590bae0a74456de885458b154120c4703729 Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Thu Jun 06 10:34:38 2019 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/36c7590bae0a74456de885458b154120c4703729 [^] fixes bug 41034: ImportEntryPreProcessors with qualifiers are not executed As part of the refactor to provide the ImportEntryBuilder[1], the injection of the import entry preprocessors was changed. As the instances of that class are created outside of the Weld scope, the preprocessors are injected using "WeldUtils.getInstances()" method instead of using @Inject. The problem here is that "WeldUtils.getInstances()" looked for all beans of an specific type that does not have a qualifier. For this reason, import entry preprocessors with qualifiers were not being found and, therefore, not executed by the ImportEntryBuilder before creating the import entry. To fix this problem now "WeldUtils.getInstances()" has been changed in order to look for any bean of a particular type (regardless of whether it is qualified or not). This is done by specifying the @Any qualifier to the "BeanManager.getBeans()" method. Thus, now WeldUtils.getInstances() behaves exactly in the same way as when using @Inject together with @Any when we are inside the scope of Weld. [1] https://code.openbravo.com/erp/devel/pi/rev/90c48060859cc70935add00e77e8065dedb197cc [^] --- M modules/org.openbravo.base.weld/src/org/openbravo/base/weld/WeldUtils.java --- |
|
(0112497) alostale (viewer) 2019-06-07 08:01 |
reviewed + tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-06-05 16:50 | caristu | Type | defect => backport |
| 2019-06-05 16:50 | caristu | Target Version | => 3.0PR19Q2.1 |
| 2019-06-06 11:09 | hgbot | Checkin | |
| 2019-06-06 11:09 | hgbot | Note Added: 0112461 | |
| 2019-06-06 11:09 | hgbot | Status | scheduled => resolved |
| 2019-06-06 11:09 | hgbot | Resolution | open => fixed |
| 2019-06-06 11:09 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/36c7590bae0a74456de885458b154120c4703729 [^] |
| 2019-06-06 11:09 | caristu | Review Assigned To | => alostale |
| 2019-06-06 13:03 | caristu | Assigned To | platform => caristu |
| 2019-06-07 08:01 | alostale | Note Added: 0112497 | |
| 2019-06-07 08:01 | alostale | Status | resolved => closed |
| 2019-06-07 08:01 | alostale | Fixed in Version | => 3.0PR19Q2.1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |