Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0040845 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
backport | [Openbravo ERP] Z. Others | minor | have not tried | 2019-04-18 14:02 | 2019-06-04 17:57 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | nonofrancisco | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR19Q1.2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | eb6ea31dec5b | ||||
Projection | none | ETA | none | Target Version | 3.0PR19Q1.2 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | Sandrahuguet | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0040845: use proper html escape in old selectors | |||||||
Description | Old 2.50 selectors should use standard html escape rather than ad-hoc one. Files to review: $ grep -l "extends HttpSecureAppServlet" src/org/openbravo/erpCommon/info/*.java src/org/openbravo/erpCommon/info/AccountElementValue.java src/org/openbravo/erpCommon/info/Account.java src/org/openbravo/erpCommon/info/AttributeSetInstance.java src/org/openbravo/erpCommon/info/BusinessPartner.java src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java src/org/openbravo/erpCommon/info/DebtPayment.java src/org/openbravo/erpCommon/info/DocTypeMultiple.java src/org/openbravo/erpCommon/info/ImageInfoBLOB.java src/org/openbravo/erpCommon/info/ImageInfo.java src/org/openbravo/erpCommon/info/Invoice.java src/org/openbravo/erpCommon/info/InvoiceLine.java src/org/openbravo/erpCommon/info/Location.java src/org/openbravo/erpCommon/info/Locator.java src/org/openbravo/erpCommon/info/LocatorMultiple.java src/org/openbravo/erpCommon/info/ProductComplete.java src/org/openbravo/erpCommon/info/Product.java src/org/openbravo/erpCommon/info/ProductMultiple.java src/org/openbravo/erpCommon/info/Project.java src/org/openbravo/erpCommon/info/ProjectMultiple.java src/org/openbravo/erpCommon/info/SalesOrder.java src/org/openbravo/erpCommon/info/SalesOrderLine.java src/org/openbravo/erpCommon/info/ShipmentReceipt.java src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java | |||||||
Steps To Reproduce | - | |||||||
Proposed Solution | See attached example. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
||||||||
|
![]() |
|
(0112390) hgbot (developer) 2019-06-04 17:54 |
Repository: erp/backports/3.0PR19Q1.2 Changeset: eb6ea31dec5bcd1af2b6619c4f80ec4983769280 Author: Nono Carballo <nonofce <at> gmail.com> Date: Thu May 09 14:52:16 2019 -0400 URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/eb6ea31dec5bcd1af2b6619c4f80ec4983769280 [^] Fixes issue 40845: Escapes properly HTML characters. Instead of escape HTML characters manually, a function to do so is used. --- M src/org/openbravo/erpCommon/info/Account.java M src/org/openbravo/erpCommon/info/AccountElementValue.java M src/org/openbravo/erpCommon/info/BusinessPartner.java M src/org/openbravo/erpCommon/info/BusinessPartnerMultiple.java M src/org/openbravo/erpCommon/info/DebtPayment.java M src/org/openbravo/erpCommon/info/DocTypeMultiple.java M src/org/openbravo/erpCommon/info/Invoice.java M src/org/openbravo/erpCommon/info/InvoiceLine.java M src/org/openbravo/erpCommon/info/Locator.java M src/org/openbravo/erpCommon/info/LocatorMultiple.java M src/org/openbravo/erpCommon/info/Product.java M src/org/openbravo/erpCommon/info/ProductComplete.java M src/org/openbravo/erpCommon/info/ProductMultiple.java M src/org/openbravo/erpCommon/info/Project.java M src/org/openbravo/erpCommon/info/ProjectMultiple.java M src/org/openbravo/erpCommon/info/SalesOrder.java M src/org/openbravo/erpCommon/info/SalesOrderLine.java M src/org/openbravo/erpCommon/info/ShipmentReceipt.java M src/org/openbravo/erpCommon/info/ShipmentReceiptLine.java --- |
(0112393) Sandrahuguet (viewer) 2019-06-04 17:57 |
code review + testing ok |
![]() |
|||
Date Modified | Username | Field | Change |
2019-05-10 20:34 | nonofrancisco | Type | defect => backport |
2019-05-10 20:34 | nonofrancisco | Target Version | => 3.0PR19Q1.2 |
2019-06-04 17:54 | hgbot | Checkin | |
2019-06-04 17:54 | hgbot | Note Added: 0112390 | |
2019-06-04 17:54 | hgbot | Status | scheduled => resolved |
2019-06-04 17:54 | hgbot | Resolution | open => fixed |
2019-06-04 17:54 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/eb6ea31dec5bcd1af2b6619c4f80ec4983769280 [^] |
2019-06-04 17:57 | Sandrahuguet | Review Assigned To | => Sandrahuguet |
2019-06-04 17:57 | Sandrahuguet | Note Added: 0112393 | |
2019-06-04 17:57 | Sandrahuguet | Status | resolved => closed |
2019-06-04 17:57 | Sandrahuguet | Fixed in Version | => 3.0PR19Q1.2 |
Copyright © 2000 - 2009 MantisBT Group |