0040833: SequenceProductCreate.getLineNum is not using bind-parameters

Description

This code is not using bind-params:

    String hql = " SELECT COALESCE(MAX(l.lineNo),0)+10 AS DefaultValue FROM ManufacturingOperationProduct l WHERE l.mASequence.id= '"
        + SequenceId + "'";
    Query<Long> q = OBDal.getInstance().getSession().createQuery(hql, Long.class);

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0040574

3.0PR19Q3

closed

nonofrancisco

SequenceProductCreate.getLineNum is not using bind-parameters

Notes
(0112425) hgbot (developer) 2019-06-05 15:26	Repository: erp/backports/3.0PR19Q1.2 Changeset: 43a60afc9f2d5c2d83dce9c8b5c9f3ccae8094af Author: Nono Carballo <nonofce <at> gmail.com> Date: Wed May 01 22:53:24 2019 -0400 URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/43a60afc9f2d5c2d83dce9c8b5c9f3ccae8094af [^] Fixes issue 40833: Uses bind parameter. Instead of string concatenation, bind parameter is used to build the query. --- M src/org/openbravo/erpCommon/ad_actionButton/SequenceProductCreate.java ---

(0112427) Sandrahuguet (viewer) 2019-06-05 15:54	code review + testing ok

Issue History
Date Modified	Username	Field	Change
2019-05-09 23:25	nonofrancisco	Type	defect => backport
2019-05-09 23:25	nonofrancisco	Target Version	=> 3.0PR19Q1.2
2019-06-05 15:26	hgbot	Checkin
2019-06-05 15:26	hgbot	Note Added: 0112425
2019-06-05 15:26	hgbot	Status	scheduled => resolved
2019-06-05 15:26	hgbot	Resolution	open => fixed
2019-06-05 15:26	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/43a60afc9f2d5c2d83dce9c8b5c9f3ccae8094af [^]
2019-06-05 15:54	Sandrahuguet	Review Assigned To	=> Sandrahuguet
2019-06-05 15:54	Sandrahuguet	Note Added: 0112427
2019-06-05 15:54	Sandrahuguet	Status	resolved => closed
2019-06-05 15:54	Sandrahuguet	Fixed in Version	=> 3.0PR19Q1.2