0040716: CashUpReport.doPost is not using bind-parameters

Description

This code is not using bind-params:

      final String hqlCashup = "SELECT netsales, grosssales, netreturns, grossreturns, totalretailtransactions " //
          + " FROM OBPOS_App_Cashup " //
          + " WHERE id = '" + cashupId + "' "; //
      final Query<Object[]> cashupQuery = OBDal.getReadOnlyInstance()
          .getSession()
          .createQuery(hqlCashup, Object[].class);

and

      final String hqlTaxes = String.format("SELECT name, STR(ABS(amount)) " //
          + " FROM OBPOS_Taxcashup " //
          + " WHERE obpos_app_cashup_id='%s' AND ordertype='0' " //
          + " ORDER BY name ", cashupId);
      final Query<Object[]> salesTaxesQuery = OBDal.getReadOnlyInstance()
          .getSession()
          .createQuery(hqlTaxes, Object[].class);

and

      final String hqlReturnTaxes = String.format("SELECT name, STR(ABS(amount)) " //
          + " FROM OBPOS_Taxcashup " //
          + " WHERE obpos_app_cashup_id='%s' AND ordertype='1' " //
          + " ORDER BY name ", cashupId);
      final Query<Object[]> returnsTaxesQuery = OBDal.getReadOnlyInstance()
          .getSession()
          .createQuery(hqlReturnTaxes, Object[].class);

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0040584

closed

ranjith_qualiantech_com

CashUpReport.doPost is not using bind-parameters

Notes
(0111412) hgbot (developer) 2019-05-02 08:21	Repository: retail/backports/3.0RR19Q2/org.openbravo.retail.posterminal Changeset: 8365c58d4244a6439a7728a7a98c8b433d166453 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu May 02 11:51:16 2019 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR19Q2/org.openbravo.retail.posterminal/rev/8365c58d4244a6439a7728a7a98c8b433d166453 [^] Fixed issue 40716 : Update CashupReport query to use query parameter --- M src/org/openbravo/retail/posterminal/ad_reports/CashUpReport.java ---

Issue History
Date Modified	Username	Field	Change
2019-04-30 11:55	shuehner	Type	defect => backport
2019-04-30 11:55	shuehner	Target Version	=> RR19Q2
2019-05-02 08:21	hgbot	Checkin
2019-05-02 08:21	hgbot	Note Added: 0111412
2019-05-02 08:21	hgbot	Status	scheduled => resolved
2019-05-02 08:21	hgbot	Resolution	open => fixed
2019-05-02 08:21	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR19Q2/org.openbravo.retail.posterminal/rev/8365c58d4244a6439a7728a7a98c8b433d166453 [^]
2019-05-02 08:30	marvintm	Review Assigned To	adrianromero => marvintm
2019-05-02 08:30	marvintm	Status	resolved => closed
2019-05-02 08:30	marvintm	Fixed in Version	=> RR19Q2