Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040683
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 09. Financial managementminorhave not tried2019-04-04 13:272019-04-25 17:00
ReporteralostaleView Statuspublic 
Assigned Tononofrancisco 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q4.4
StatusclosedFix in branchFixed in SCM revisioncad0e7a1e663
ProjectionnoneETAnoneTarget Version3.0PR18Q4.4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040683: use bind-parameters in FIN_BankStatementImport

DescriptionFIN_BankStatementImport.matchBusinessPartnerByNameTokens method is generating a sql setting parameters by String concatenation, replace tokens by bind parameters.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0040522 closednonofrancisco use bind-parameters in FIN_BankStatementImport 

-  Notes
(0111329)
Sandrahuguet (viewer)
2019-04-25 16:59

 Repository: erp/backports/3.0PR18Q4.4
Changeset: cad0e7a1e66397273227a5757b4c854c7f4f1a56
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Apr 25 16:45:42 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4.4/rev/cad0e7a1e66397273227a5757b4c854c7f4f1a56 [^] [^]

Fixes issue 40522: Prevents use of string concatenation in query

Query to get business partners was formed using string concatenation.
This fix replaces the string concatenation by bind parameters in query.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111330)
Sandrahuguet (viewer)
2019-04-25 16:59

 Repository: erp/backports/3.0PR18Q4.4
Changeset: 3d746e160cc98f70758caba7182ce916408d9537
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Apr 25 16:46:48 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4.4/rev/3d746e160cc98f70758caba7182ce916408d9537 [^] [^]

related to issue 40522 code review changes

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111331)
Sandrahuguet (viewer)
2019-04-25 17:00

 Code review + testing OK

- Issue History
Date Modified Username Field Change
2019-04-25 13:20 Sandrahuguet Type defect => backport
2019-04-25 13:20 Sandrahuguet Target Version => 3.0PR18Q4.4
2019-04-25 16:59 Sandrahuguet Note Added: 0111329
2019-04-25 16:59 Sandrahuguet Note Added: 0111330
2019-04-25 17:00 Sandrahuguet Status scheduled => resolved
2019-04-25 17:00 Sandrahuguet Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/a5d02171e10c523cfac9da2c54e6fb29ee292514 [^] => https://code.openbravo.com/erp/backports/3.0PR18Q4.4/rev/cad0e7a1e66397273227a5757b4c854c7f4f1a56 [^]
2019-04-25 17:00 Sandrahuguet Resolution open => fixed
2019-04-25 17:00 Sandrahuguet Review Assigned To => Sandrahuguet
2019-04-25 17:00 Sandrahuguet Note Added: 0111331
2019-04-25 17:00 Sandrahuguet Status resolved => closed
2019-04-25 17:00 Sandrahuguet Fixed in Version => 3.0PR18Q4.4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker