Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040682
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 09. Financial managementminorhave not tried2019-04-04 13:272019-04-25 16:54
ReporteralostaleView Statuspublic 
Assigned Tononofrancisco 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q1.1
StatusclosedFix in branchFixed in SCM revision04e077fb1d4c
ProjectionnoneETAnoneTarget Version3.0PR19Q1.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040682: use bind-parameters in FIN_BankStatementImport

DescriptionFIN_BankStatementImport.matchBusinessPartnerByNameTokens method is generating a sql setting parameters by String concatenation, replace tokens by bind parameters.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0040522 closednonofrancisco use bind-parameters in FIN_BankStatementImport 

-  Notes
(0111323)
hgbot (developer)
2019-04-25 16:45

Repository: erp/backports/3.0PR19Q1.1
Changeset: 04e077fb1d4c68d5023019b8029a6696820bbb65
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Apr 25 12:39:23 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.1/rev/04e077fb1d4c68d5023019b8029a6696820bbb65 [^]

Fixes issue 40682: Prevents use of string concatenation in query

Query to get business partners was formed using string concatenation.
This fix replaces the string concatenation by bind parameters in query.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111324)
hgbot (developer)
2019-04-25 16:45

Repository: erp/backports/3.0PR19Q1.1
Changeset: bbf97c4e9834124a4c16b0872cc4573f90ad8457
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Apr 25 13:12:34 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.1/rev/bbf97c4e9834124a4c16b0872cc4573f90ad8457 [^]

related to issue 40682 code review changes

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0111326)
Sandrahuguet (developer)
2019-04-25 16:54

Code review + testing OK

- Issue History
Date Modified Username Field Change
2019-04-25 13:20 Sandrahuguet Type defect => backport
2019-04-25 13:20 Sandrahuguet Target Version => 3.0PR19Q1.1
2019-04-25 16:45 hgbot Checkin
2019-04-25 16:45 hgbot Note Added: 0111323
2019-04-25 16:45 hgbot Status scheduled => resolved
2019-04-25 16:45 hgbot Resolution open => fixed
2019-04-25 16:45 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/a5d02171e10c523cfac9da2c54e6fb29ee292514 [^] => http://code.openbravo.com/erp/backports/3.0PR19Q1.1/rev/04e077fb1d4c68d5023019b8029a6696820bbb65 [^]
2019-04-25 16:45 hgbot Checkin
2019-04-25 16:45 hgbot Note Added: 0111324
2019-04-25 16:54 Sandrahuguet Review Assigned To => Sandrahuguet
2019-04-25 16:54 Sandrahuguet Note Added: 0111326
2019-04-25 16:54 Sandrahuguet Status resolved => closed
2019-04-25 16:54 Sandrahuguet Fixed in Version => 3.0PR19Q1.1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker