Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040589
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Mobile Procurementminorhave not tried2019-04-10 17:572019-05-24 12:55
ReportershuehnerView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR19Q3
StatusclosedFix in branchFixed in SCM revisioned30315a0d94
ProjectionnoneETAnoneTarget VersionRR19Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040589: POrderLoaderEntryProcessor.countEntries is not using bind-parameters & should be reviewed if not generic super.countEntries

DescriptionThis countEntries method is copy'n'pasted and not using a bind-parameter for importStatus.

Before fixing this the file should be reviewed if the countEntries logic is correct (the filters).
Also review if not the super-class countEntries can be used similarly to most of the i.e. posterminal processor classes.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0038136 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0111708)
hgbot (developer)
2019-05-16 10:02

 Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: 46a5f8af3e1bf47ae06a6e1fec578c6744bce268
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 16 13:32:40 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/46a5f8af3e1bf47ae06a6e1fec578c6744bce268 [^]

Fixed issue 40589 : POrderLoaderEntryProcessor.countEntries is not using bind-parameters

---
M src/org/openbravo/mobile/procurement/sync/POrderLoaderEntryProcessor.java
---
(0111767)
hgbot (developer)
2019-05-17 10:04

 Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: ed30315a0d946dbd5564ca70c8539e90eb512845
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri May 17 13:25:26 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/ed30315a0d946dbd5564ca70c8539e90eb512845 [^]

Fixed issue 40589 : POrderLoaderEntryProcessor.countEntries is not using bind-parameters

---
M src/org/openbravo/mobile/procurement/sync/POrderLoaderEntryProcessor.java
---

- Issue History
Date Modified Username Field Change
2019-04-10 17:57 shuehner New Issue
2019-04-10 17:57 shuehner Assigned To => Retail
2019-04-10 17:57 shuehner Triggers an Emergency Pack => No
2019-04-10 17:57 shuehner Category Web POS => Mobile Procurement
2019-04-10 17:57 shuehner Relationship added blocks 0038136
2019-05-13 12:45 shuehner Target Version => RR19Q3
2019-05-15 07:42 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2019-05-15 07:42 ranjith_qualiantech_com Status new => scheduled
2019-05-16 10:02 hgbot Checkin
2019-05-16 10:02 hgbot Note Added: 0111708
2019-05-16 10:02 hgbot Status scheduled => resolved
2019-05-16 10:02 hgbot Resolution open => fixed
2019-05-16 10:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/46a5f8af3e1bf47ae06a6e1fec578c6744bce268 [^]
2019-05-17 10:04 hgbot Checkin
2019-05-17 10:04 hgbot Note Added: 0111767
2019-05-17 10:04 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/46a5f8af3e1bf47ae06a6e1fec578c6744bce268 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/ed30315a0d946dbd5564ca70c8539e90eb512845 [^]
2019-05-24 12:55 marvintm Review Assigned To => marvintm
2019-05-24 12:55 marvintm Status resolved => closed
2019-05-24 12:55 marvintm Fixed in Version => RR19Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker