0040220: Warnings for Validation type: KILLABLENOTIMPLEMENTED

Description

The French Fiscal module includes several background processes that do properly implement the killable feature. The module is distributed with a JAR file without src folder.

There is a validation that checks whether a process declared as killable properly implements it. This validation is failing when the process is included into a JAR file. However, when the same process is distributed into the src folder, the validation does pass successfully.

It seems it's necessary to improve the validation to avoid the warnings when the class is inside a JAR file.

Steps To Reproduce

See mod-obcfr job execution. Example:

* FAILURE: Errors in the dbconsistency-exportdb.log
LOG: https://ci.openbravo.com/job/mod-simple/34772/artifact/dbconsistency-exportdb.log/*view*/ [^]
Log errors:
    [java] 68591 [main] WARN org.openbravo.ddlutils.task.ExportDatabase -
    [java] 68592 [main] WARN org.openbravo.ddlutils.task.ExportDatabase - +++++++++++++++++++++++++++++++++++++++++++++++++++
    [java] 68593 [main] WARN org.openbravo.ddlutils.task.ExportDatabase - Warnings for Validation type: KILLABLENOTIMPLEMENTED
    [java] 68594 [main] WARN org.openbravo.ddlutils.task.ExportDatabase - +++++++++++++++++++++++++++++++++++++++++++++++++++
    [java] 68594 [main] WARN org.openbravo.ddlutils.task.ExportDatabase - Error trying to obtain the class for process Blockchain Verification Background
    [java] 68595 [main] WARN org.openbravo.ddlutils.task.ExportDatabase - Error trying to obtain the class for process French Fiscal Archiving

http://ci.openbravo.com/job/mod-simple/34772/artifact/errors.log [^]

Proposed Solution

Add module's jars to the classpath used when doing validations when exporting DB.

https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/service/system/DatabaseValidator.java#l882 [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0040335		closed	jarmendariz	Change validation type when class implementing Killable is not found
related to	feature request	0040302		acknowledged	Triage Platform Base	Make white list extendable from extenal modules for database validation

Notes
(0110278) jarmendariz (developer) 2019-03-07 12:33	In this case the validation is correct: not finding the implementation of the Killable class in the classpath show trigger a warning. In the particular case of the French Fiscal Module this warning should be ignored as this is a controlled case. However, to make easier the identification and filtering of this warning, a new validation type will be added in 0040335.

Issue History
Date Modified	Username	Field	Change
2019-02-15 12:27	vmromanos	New Issue
2019-02-15 12:27	vmromanos	Assigned To	=> platform
2019-02-15 12:27	vmromanos	Modules	=> Core
2019-02-15 12:27	vmromanos	Triggers an Emergency Pack	=> No
2019-03-01 09:36	alostale	Relationship added	related to 0040302
2019-03-01 09:36	alostale	Status	new => acknowledged
2019-03-04 17:04	jarmendariz	Assigned To	platform => jarmendariz
2019-03-04 17:04	jarmendariz	Status	acknowledged => scheduled
2019-03-07 12:21	jarmendariz	Relationship added	related to 0040335
2019-03-07 12:33	jarmendariz	Review Assigned To	=> jarmendariz
2019-03-07 12:33	jarmendariz	Note Added: 0110278
2019-03-07 12:34	jarmendariz	Status	scheduled => closed
2019-03-07 12:34	jarmendariz	Resolution	open => no change required