Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038950 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2018-07-13 12:15 | 2019-05-21 15:16 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR19Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 66c41204bce2 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038950: use bind-parameters in Preferences.java | |||||||
| Description | This piece of code is injecting params by String concatenation: List<String> parentTree = OBContext.getOBContext().getOrganizationStructureProvider(client) .getParentList(org, true); String parentOrgs = "(" + StringCollectionUtils.commaSeparated(parentTree) + ")"; hql.append(" and coalesce(p.visibleAtOrganization, '0') in " + parentOrgs); | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Hibernate supports setting IN parameters as a Collection, replace this code for a param. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0111352) hgbot (developer) 2019-04-26 10:27 |
Repository: erp/devel/pi Changeset: 66c41204bce2f25473854a6851a228f568705da6 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Apr 25 13:50:52 2019 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/66c41204bce2f25473854a6851a228f568705da6 [^] fixed issue 38950: use bind-parameters in Preferences.java --- M src/org/openbravo/erpCommon/businessUtility/Preferences.java --- |
|
(0111626) caristu (developer) 2019-05-10 15:27 |
Code reviewed + tested OK. |
|
(0112001) hudsonbot (developer) 2019-05-21 15:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b8f37d9d85e [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-07-13 12:15 | alostale | New Issue | |
| 2018-07-13 12:15 | alostale | Assigned To | => platform |
| 2018-07-13 12:15 | alostale | Modules | => Core |
| 2018-07-13 12:15 | alostale | Triggers an Emergency Pack | => No |
| 2018-07-13 12:15 | alostale | Relationship added | blocks 0038136 |
| 2018-08-03 08:57 | alostale | Status | new => acknowledged |
| 2019-04-26 10:27 | hgbot | Checkin | |
| 2019-04-26 10:27 | hgbot | Note Added: 0111352 | |
| 2019-04-26 10:27 | hgbot | Status | acknowledged => resolved |
| 2019-04-26 10:27 | hgbot | Resolution | open => fixed |
| 2019-04-26 10:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/66c41204bce2f25473854a6851a228f568705da6 [^] |
| 2019-04-29 17:28 | shuehner | Assigned To | platform => alostale |
| 2019-05-03 07:46 | alostale | Review Assigned To | => caristu |
| 2019-05-10 15:27 | caristu | Note Added: 0111626 | |
| 2019-05-10 15:27 | caristu | Status | resolved => closed |
| 2019-05-10 15:27 | caristu | Fixed in Version | => 3.0PR19Q3 |
| 2019-05-21 15:16 | hudsonbot | Checkin | |
| 2019-05-21 15:16 | hudsonbot | Note Added: 0112001 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |