Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038877
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2018-07-03 09:042018-07-04 17:38
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiondbb1d539c50a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038877: incorrect query in TaxZone model

DescriptionThe HQL query defined in the getQuery method of the TaxZone model has incorrect bracket balance.

Hibernate 3.6 allows it whereas it is not allowed in newer versions.
Steps To Reproduce1. Using Hibernate 5.3 (https://code.openbravo.com/erp/devel/pi-hb53 [^])
2. Login in WebPOS
  -> ERROR:
     ....
     org.openbravo.mobile.core.process.ProcessHQLQuery - org.openbravo.retail.posterminal.master.TaxZone: Error when generating query: null (org.hibernate.hql.internal.ast.QuerySyntaxException: expecting EOF, found ')' near line 7, column 1330 [select financialMgmtTaxZone.id as id,
financialMgmtTaxZone.tax.id as tax,
financialMgmtTaxZone.fromCountry.id as fromCountry,
financialMgmtTaxZone.destinationCountry.id as destinationCountry,
financialMgmtTaxZone.fromRegion.id as fromRegion,
financialMgmtTaxZone.destinationRegion.id as destinationRegion,
financialMgmtTaxZone.active as active from FinancialMgmtTaxZone as financialMgmtTaxZone where ( (financialMgmtTaxZone.client.id in ('39363B0921BB4293B48383844325E84C', '0')) ) AND ( financialMgmtTaxZone.organization.id in (:valueEqArray0 )) AND ( financialMgmtTaxZone.updated> :valueDate1 ) and financialMgmtTaxZone.tax in (select financialMgmtTaxRate.id from FinancialMgmtTaxRate as financialMgmtTaxRate where financialMgmtTaxRate.salesPurchaseType in ('S', 'B') and (financialMgmtTaxRate.country.id = :fromCountryId or (financialMgmtTaxRate.country is null and (not exists (select z from FinancialMgmtTaxZone as z where z.tax = financialMgmtTaxRate)) or exists (select z from FinancialMgmtTaxZone as z where z.tax = financialMgmtTaxRate and z.fromCountry.id = :fromCountryId ) or exists (select z from FinancialMgmtTaxZone as z where z.tax = financialMgmtTaxRate and z.fromCountry is null)))and (financialMgmtTaxRate.region.id = :fromRegionId or (financialMgmtTaxRate.region is null and (not exists (select z from FinancialMgmtTaxZone as z where z.tax = financialMgmtTaxRate)) or exists (select z from FinancialMgmtTaxZone as z where z.tax = financialMgmtTaxRate and z.fromRegion.id = :fromRegionId ) or exists (select z from FinancialMgmtTaxZone as z where z.tax = financialMgmtTaxRate and z.fromRegion is null)))))and (financialMgmtTaxZone.fromCountry.id = :fromCountryId or financialMgmtTaxZone.fromCountry is null) and (financialMgmtTaxZone.fromRegion.id = :fromRegionId or financialMgmtTaxZone.fromRegion is null) order by financialMgmtTaxZone.id asc])
...
Proposed SolutionSee attached file with the proposal
TagsNo tags attached.
Attached Filesdiff file icon taxZone.diff [^] (986 bytes) 2018-07-03 09:04 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 0037064 closedcaristu Openbravo ERP upgrade hibernate to 5.3.2 

-  Notes
(0105539)
hgbot (developer)
2018-07-03 10:05

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dbb1d539c50a9e731c6433f01d63d6baa70ed728
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jul 03 10:03:18 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbb1d539c50a9e731c6433f01d63d6baa70ed728 [^]

fixes issue 38877: query for the TaxZone model has incorrect bracket balance

---
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0105594)
migueldejuana (developer)
2018-07-04 17:38

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2018-07-03 09:04 caristu New Issue
2018-07-03 09:04 caristu Assigned To => platform
2018-07-03 09:04 caristu File Added: taxZone.diff
2018-07-03 09:04 caristu Modules => Core
2018-07-03 09:04 caristu Triggers an Emergency Pack => No
2018-07-03 09:04 caristu Issue generated from 0038735
2018-07-03 09:04 caristu Project Openbravo ERP => Retail Modules
2018-07-03 09:05 caristu Assigned To platform => Retail
2018-07-03 09:05 caristu Category A. Platform => Aging Balance Report
2018-07-03 09:05 caristu Steps to Reproduce Updated View Revisions
2018-07-03 09:05 caristu Category Aging Balance Report => Web POS
2018-07-03 09:05 caristu Relationship added blocks 0037064
2018-07-03 09:06 caristu Steps to Reproduce Updated View Revisions
2018-07-03 09:06 caristu Steps to Reproduce Updated View Revisions
2018-07-03 10:05 hgbot Checkin
2018-07-03 10:05 hgbot Note Added: 0105539
2018-07-03 10:05 hgbot Status new => resolved
2018-07-03 10:05 hgbot Resolution open => fixed
2018-07-03 10:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbb1d539c50a9e731c6433f01d63d6baa70ed728 [^]
2018-07-03 10:06 caristu Review Assigned To => migueldejuana
2018-07-03 10:06 caristu Assigned To Retail => caristu
2018-07-04 17:38 migueldejuana Note Added: 0105594
2018-07-04 17:38 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker